Repository navigation
Feat session import downloads - #931
Merged
Merged
Conversation
Creylay
added this pull request to stack #928
October 21, 2026 11:19
cristian-tamblay
force-pushed
the
feat/session-import-downloads
branch
from
October 21, 2026 19:02
679622b to
b0b34fc
Compare
cristian-tamblay
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a session imported from a
.dashaifile uses a model that must be downloaded first (e.g. a HuggingFace translator) and the installation does not have it, the import succeeded silently and the problem only showed up later, when training or retraining. Now the import reports which models (including nested components in a run's parameters) are not downloaded, split by whether their run arrived trained:A model missing for both kinds is listed only as untrained, since that is the blocking case.
The import UI was also reworked. Previously the modal closed as soon as a file was chosen, the only sign of a long import was a small spinner in the Sessions header, and the notices were snackbars that piled up and auto-closed before they could be read. Now the whole import happens in one modal: the trust warning, a progress state that cannot be dismissed while the request runs, and a result view with every notice that stays open until Got it. An import with nothing to report just shows the success snackbar.
Type of Change
Check all that apply like this [x]:
Changes (by file)
DashAI/back/session_package/load.py: new_missing_downloads, which checks every run's model and its nested components againstREQUIRES_DOWNLOADand the current download status. The import result now includesneeds_download_trainedandneeds_download_untrained, each withnameand adisplay_namein the requested language.DashAI/back/api/api_v1/endpoints/model_sessions.py: the import endpoint readsAccept-Languageand passes it on, so display names come in the app language.DashAI/front/src/types/modelSession.ts:IMissingDownloadand the two new fields ofISessionImportResult.DashAI/front/src/utils/i18n/locales/{en,es,pt,de,zh}/models.json: download notices, progress text, "Session imported" title and "Got it".docs/.../tutorials/Models/share-session.md(en, es): explains the download notices and why trained runs only need the download to retrain.tests/back/api/test_session_package.py: missing downloads split by trained/untrained, already downloaded or download-free models not listed, and display names in the app language.DashAI/front/src/components/models/ImportSessionButton.test.jsx: no-notice import shows only the snackbar, notices stay in the modal until dismissed, and the Download button downloads every untrained model.Testing (optional)