Repository navigation
Document compiler visibility for the SQL syntax property - #231
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
SQL Syntax option 4 currently says setting
Dapper_SqlSyntaxin aPropertyGroupis enough. In a NuGet consumer, that MSBuild property is not automatically visible to the analyzer:GlobalOptionsreadsbuild_property.Dapper_SqlSyntax, which requires aCompilerVisiblePropertyitem.The repository itself already supplies the item in
Directory.Build.props, but consumers do not inherit that file.Change
Show the complete project-file configuration, including the compiler-visible item, and explain why it is needed. No analyzer or package behavior changes.
Validation
Built a standalone net10.0 library using Dapper.Advisor 1.1.0 and Dapper 2.1.79. Its synthetic
DbConnection.QueryFirst<Product>("select * from Products where Id = @id", new { id = 7 })call gives no SQL Server diagnostic with the property alone. Adding the documented item makes the same build report DAP219 as expected. This was compilation-only; no SQL Server connection or real database was used.