Skip to content

Adjusted the allowed TP stream fragment sizes upward in sample_ehn1_multihost_test… - #359

Open
bieryAtFnal wants to merge 1 commit into
developfrom
kbiery/SEMT_tpstream_fragment_adjustment
Open

bieryAtFnal wants to merge 1 commit into
developfrom
kbiery/SEMT_tpstream_fragment_adjustment

Conversation

@bieryAtFnal

Copy link
Copy Markdown
Collaborator

…to take into account Theo's fix for the TP_rate_per_channel in SourceEmulatorModel (which admittedly has been available for a while now).

Description

Recently, Michal noticed that the sample_ehn1_multihost_test.py was reporting problems like the following:

TP Stream fragment for SrcID Trigger_0x000003ea in record (19, 0) has size 231000 (outside range [170000, 230000])

I believe that the problem is that we did not appropriately adjust the allowed range of TP stream fragment sizes upward in the sample_ehn1_multihost_test when we rolled out Theo's fix for the TP_rate_per_channel in datahandlinglibs/SourceEmulatorModel.

To help verify this theory, I looked at the observed increase in the TP stream fragment size in a different test (tpstream_writing_test) when Theo's changes went live. That was ~4.8%.

That is the same increase that the TP stream fragment sizes in sample_ehn1_multihost_test.py experienced, but the allowed size range in the tpstream_writing_test was wide enough to accommodate the increase, and the allowed range in the sample_ehn1_multihost_test was not.

This PR adjusts the allowed sizes appropriately, and with that change, I see the sample_ehn1_multihost_test now pass.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Testing checklist

  • Full set of integration tests pass (dunedaq_integtest_bundle.sh)

…ulthost_test.py to take into account Theo's fix for the TP_rate_per_channel in SourceEmulatorModel (which admittedly has been available for a while now).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants