Repository navigation
Adjusted the allowed TP stream fragment sizes upward in sample_ehn1_multihost_test… - #359
Open
bieryAtFnal wants to merge 1 commit into
Open
bieryAtFnal wants to merge 1 commit into
bieryAtFnal wants to merge 1 commit into
Conversation
…ulthost_test.py to take into account Theo's fix for the TP_rate_per_channel in SourceEmulatorModel (which admittedly has been available for a while now).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…to take into account Theo's fix for the
TP_rate_per_channelinSourceEmulatorModel(which admittedly has been available for a while now).Description
Recently, Michal noticed that the
sample_ehn1_multihost_test.pywas reporting problems like the following:I believe that the problem is that we did not appropriately adjust the allowed range of TP stream fragment sizes upward in the
sample_ehn1_multihost_testwhen we rolled out Theo's fix for theTP_rate_per_channelindatahandlinglibs/SourceEmulatorModel.To help verify this theory, I looked at the observed increase in the TP stream fragment size in a different test (
tpstream_writing_test) when Theo's changes went live. That was ~4.8%.That is the same increase that the TP stream fragment sizes in
sample_ehn1_multihost_test.pyexperienced, but the allowed size range in thetpstream_writing_testwas wide enough to accommodate the increase, and the allowed range in thesample_ehn1_multihost_testwas not.This PR adjusts the allowed sizes appropriately, and with that change, I see the
sample_ehn1_multihost_testnow pass.Type of change
Testing checklist
dunedaq_integtest_bundle.sh)