Conversation
This PR lowers the rate at which the Lua VM checks to see if it's been asked to die (using the`kill-lua` command) from once every 256 to once every 16384 instructions. Empirical testing indicates that rate still results in the interrupt flag being checked at least once every 10 milliseconds or so, which should be more than fit for purpose. The instrumentation used to gather the testing data is left in place; at the new lowered interrupt frequency, the cost of gathering it is negligible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR lowers the rate at which the Lua VM checks to see if it's been asked to die (using the
kill-luacommand) from once every 256 to once every 16384 instructions. Empirical testing indicates that rate still results in the interrupt flag being checked at least once every 10 milliseconds or so, which should be more than fit for purpose.The instrumentation used to gather the testing data is left in place; at the new lowered interrupt frequency, the cost of gathering it is negligible.