Repository navigation
Fix vengeance spirit hitbox not matching inner entity - #1286
Merged
rubensworks merged 2 commits intoOct 14, 2026
Merged
Conversation
Backport of #1279, plus refreshing dimensions after construction. Dimensions were only refreshed on pose changes, so spirits kept their 1x1 dummy hitbox. Since the random inner entity is set while defining synced data, it also does not trigger onSyncedDataUpdated, so refresh dimensions once at the end of the constructor. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018a47GR9aPVBj2dRfWzzhdN
rubensworks
commented
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.20 counterpart of #1279 and #1284. The issue from #1278 (focus beams only hitting the legs of tall spirits) also applies here, because this branch never got #1279.
Changes
onSyncedDataUpdatedto refresh dimensions when the inner entity, swarm flag or swarm tier changes. Before this, dimensions were only refreshed on pose changes, so spirits kept the 1x1 dummy hitbox.refreshDimensions()at the end of the constructor. The random inner entity is set while defining synced data, which never firesonSyncedDataUpdated. Without this, a spirit whose later inner type equals its random initial type would still keep the 1x1 hitbox.Verification
./gradlew buildpasses (compile + unit tests). This branch has no game tests, so I could not run the regression tests from #1279/#1284 here. The same change was verified with game tests on 1.21.1 and 26.3 in #1284.🤖 Generated with Claude Code
https://claude.ai/code/session_018a47GR9aPVBj2dRfWzzhdN
Generated by Claude Code