Skip to content

update Go and modules - #36

Open
Ulexus wants to merge 3 commits into
masterfrom
sean/go-mod-update
Open

Ulexus wants to merge 3 commits into
masterfrom
sean/go-mod-update

Conversation

@Ulexus

@Ulexus Ulexus commented Nov 10, 2026 •

Copy link
Copy Markdown
Member

Dependabot is complaining, and it has been a while. This is the result of go mod -u (and then updating the nix vendorHash with the new value), to update the Go dependencies. This should probably also be done for the javascript ones...

This also adds a nix devShell in which a "lint" script is available, which will call golangci-lint after building the app. This was a pain before because the app/* files needed to exist before golangci-lint could be run, and with the new build mechanisms, there is no longer a reason to have those built in that location.

To note, an easy way to use the dev shell is by creating a .envrc file in the root of the repo with the contents:

use flake

Then, ensure you have direnv installed. After that, when you change into this project's directory, your shell will enter the devShell for this project.

@Ulexus
Ulexus force-pushed the sean/go-mod-update branch from 2c7b729 to 92a49eb Compare November 10, 2026 18:37
@Ulexus
Ulexus requested review from colinbdclark and a balanced review from Copilot November 10, 2026 18:37

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The overlay is exported under incompatible per-system attributes, breaking existing consumers and flake checks, while the lint script can silently mask frontend build failures.

2 open issues
What changed in this PR

Updates Audimance’s Go toolchain and dependencies in response to Dependabot alerts, alongside Nix build and development-environment changes.

Changes:

  • Raises the Go requirement to 1.26.0 and refreshes module versions and checksums.
  • Refactors Nix outputs around flake-utils, adds a development shell and lint script, and updates the Go vendor hash.
  • Switches request-logging middleware, corrects port-number error formatting, and ignores local direnv files.
File Description
main.go Switches to RequestLogger middleware.
internal/​osc/​osc.go Formats invalid port numbers as decimal integers.
go.sum Refreshes dependency checksums.
go.mod Updates the Go requirement and module versions.
flake.nix Refactors outputs, adds development tooling, and updates the vendor hash.
flake.lock Locks the new flake-utils and systems inputs.
.gitignore Ignores .direnv and .envrc.

Review effort: Balanced

Comment thread flake.nix Resolved
Comment thread flake.nix Resolved
@Ulexus
Ulexus force-pushed the sean/go-mod-update branch from 92a49eb to ff13af8 Compare November 10, 2026 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants