Repository navigation
Conversation
Ulexus
force-pushed
the
sean/go-mod-update
branch
from
November 10, 2026 18:37
2c7b729 to
92a49eb
Compare
Ulexus
requested review from
colinbdclark
and
a balanced review from Copilot
November 10, 2026 18:37
There was a problem hiding this comment.
🟡 Changes recommended
The overlay is exported under incompatible per-system attributes, breaking existing consumers and flake checks, while the lint script can silently mask frontend build failures.
2 open issues
What changed in this PR
Updates Audimance’s Go toolchain and dependencies in response to Dependabot alerts, alongside Nix build and development-environment changes.
Changes:
- Raises the Go requirement to 1.26.0 and refreshes module versions and checksums.
- Refactors Nix outputs around
flake-utils, adds a development shell and lint script, and updates the Go vendor hash. - Switches request-logging middleware, corrects port-number error formatting, and ignores local direnv files.
| File | Description |
|---|---|
| main.go | Switches to RequestLogger middleware. |
| internal/osc/osc.go | Formats invalid port numbers as decimal integers. |
| go.sum | Refreshes dependency checksums. |
| go.mod | Updates the Go requirement and module versions. |
| flake.nix | Refactors outputs, adds development tooling, and updates the vendor hash. |
| flake.lock | Locks the new flake-utils and systems inputs. |
| .gitignore | Ignores .direnv and .envrc. |
Review effort: Balanced
Ulexus
force-pushed
the
sean/go-mod-update
branch
from
November 10, 2026 19:05
92a49eb to
ff13af8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Dependabot is complaining, and it has been a while. This is the result of
go mod -u(and then updating the nix vendorHash with the new value), to update the Go dependencies. This should probably also be done for the javascript ones...This also adds a nix devShell in which a "lint" script is available, which will call
golangci-lintafter building the app. This was a pain before because theapp/*files needed to exist beforegolangci-lintcould be run, and with the new build mechanisms, there is no longer a reason to have those built in that location.To note, an easy way to use the dev shell is by creating a
.envrcfile in the root of the repo with the contents:Then, ensure you have
direnvinstalled. After that, when you change into this project's directory, your shell will enter the devShell for this project.