Repository navigation
Simplified timetable check and used HTTPS for map tiles - #1828
Merged
david-yz-liu merged 2 commits intoNov 7, 2026
Merged
david-yz-liu merged 2 commits into
david-yz-liu merged 2 commits into
Conversation
…http to https in CampusMap.tsx
Coverage Report for CI Build 42243619020Coverage decreased (-0.03%) to 60.762%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
david-yz-liu
approved these changes
Nov 7, 2026
david-yz-liu
left a comment
Contributor
There was a problem hiding this comment.
Nice work, @danielrafailov!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR makes two small improvements to the timetable and map components:
Simplified timetable availability check in
Description.tsx: Removed the redundantObject.keys(sessions).length !== 0condition from thetimetableUnavailablecheck (line 22). This condition was unnecessary because optional chaining handles the caee when all three session arrays (F, S, Y) are empty or undefined. The simplified logic is clearer and achieves the same result.Updated map tile URL to HTTPS in
CampusMap.tsx: Changed the OpenStreetMap tile layer URL from HTTP to HTTPS (line 154). While HTTP currently works, using HTTPS is a security best practice and prevents potential mixed content warnings when the application is served over HTTPS.These changes improve code clarity and follow security best practices without affecting functionality.
Type of Change
Checklist
Before opening your pull request:
After opening your pull request: