Repository navigation
feat(cli): add Java toolchain diagnostics to concore doctor - #631
Somya-jain0811 wants to merge 1 commit into
Conversation
| "Linux": "sudo apt install julia", | ||
| "Darwin": "brew install julia", | ||
| "Windows": "winget install -e --id JuliaLang.Julia", |
There was a problem hiding this comment.
Both of these fail if you copy them. winget -e is case-sensitive and the real ID is Julialang.Julia, so JuliaLang.Julia gives "No package found" (tried it on my machine). Ubuntu 22.04 and 24.04 also don't have a julia package anymore. I'd point to juliaup instead: curl -fsSL https://install.julialang.org | sh on Linux and `winget install -e --id
| "Windows": "winget install -e --id EclipseAdoptium.Temurin.17.JDK", | ||
| }, | ||
| }, | ||
| "Julia": { |
There was a problem hiding this comment.
Not sure a host julia check fits here. mkconcore only handles .jl nodes in docker mode (mkconcore.py:647) and they run inside the julia:1.10 image, so the local julia never gets used for a study. So a docker user with a Julia node gets a warning for something they don't need, and someone with julia installed sees + Julia even though a posix build won't run a .jl node. I'd either drop it or make the label say it's only for running the Julia tests locally.
bc25240 to
8e9f82e
Compare
Somya-jain0811
changed the title
|
Good catch @Sahil-u07, thanks for pointing that out! I checked I've updated the PR to drop the Julia check completely so we stay focused just on |
Fixes #630
concore doctorverified C++, Python, Verilog, Octave, MATLAB, and Docker, but omitted Java.This PR adds:
Java (javac)detection withJAVACEXEandJAVACWINtool path config support.!when absent rather than hard failure).apt), macOS (brew), and Windows (winget).Added unit tests in
tests/test_doctor.pycovering tool definitions, presence detection, version flag output parsing (including older JDK stderr fallback), and CLI reporting.Tests pass locally:
ruff format --check .(clean)ruff check .(clean)pytest tests/test_doctor.py tests/test_setup.py(30 passed in 4.97s)