Repository navigation
feat(example-sets): a fragment may let the set's own accounts follow its objects - #4760
Merged
Merged
Conversation
…its objects A follower is a row in openregister_watchers. The loader had no part for it, so no example case could show who follows it. A fragment's watchers rows are now checked, written through WatcherMapper::subscribe, proved and taken away on remove. The Zuiddrecht cast gains Anouk Bakker, who follows dossiq's Woo case on the DqZaak board. Assisted-by: ClaudeCode:claude-opus-5-5
Contributor
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ❌ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ✅ | ||||
| test-l10n-parity | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 173/173 | |||
| npm | ✅ | ✅ 648/648 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ | ||||
| Newman | ❌ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-10-21 20:46 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
watchers. A fragment may let one of the set's own accounts follow one of its objects:{user, objectUuid, register?, schema?, notify?}.WatcherMapper::subscribeand recorded as the user and object pair.notifyand any other field.anouk.bakker, Juridische zaken), the AB the dossiq DqZaak board draws as a follower.Why
Followers live in
openregister_watchers, which no example-set part wrote. So no demo case could show who follows it.Verified
ExampleSetWatchersTestcovers a write, a second install that keeps the follow, a follow reported missing, remove, and 5 refusal cases.tests/Unit/Service/ExampleSetsuite passes: 158 tests. I updated the remove-report expectation and the cast count from 18 to 19.lib/Service/ExampleSet; phpcs is clean on the new files.Note
The watcher row that makes Anouk follow the DqZaak case goes in portaliq's fragment, not dossiq's. The case is portaliq's
woo-fietspad, and dossiq's fragment installs before portaliq's, so dossiq cannot reference it.AI-assisted: written with Claude Code (claude-opus-5-5) and reviewed before submission.