Repository navigation
feat(example-sets): a fragment may give a task its checklist - #4758
Merged
Merged
Conversation
The task engine keeps a checklist on a task and the task page draws it,
but ExampleSetTasks refused the field, so no example task could show
one. The check now accepts a list of {id, label, checked} items and
refuses a malformed one before anything is written.
Assisted-by: ClaudeCode:claude-opus-5-5
Contributor
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ❌ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ✅ | ||||
| test-l10n-parity | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 173/173 | |||
| npm | ✅ | ✅ 648/648 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ | ||||
| Newman | ❌ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-10-21 20:33 UTC
Download the full PDF report from the workflow artifacts.
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
An example set's task may now declare a
checklist: a list of{id, label, description?, checked?}items, written to the task engine as declared. The check refuses a checklist that is not a list, an item without an id or a label, an id used twice and acheckedthat is not true or false.Why
dossiq's DqTaak board draws a task with a Checklist card ("2 van 4 klaar"). The engine and the task page already support a checklist, but
ExampleSetTasks::FIELDSdid not list it. So a fragment that declared one was refused, and that refusal stops the whole set from installing.Verified
ExampleSetTasksTest: 20 tests pass. That includes a new test that writes a task with its checklist and four new refusal cases.ExampleSetTasks.php. The phpcs findings in the test file are on lines this PR does not touch.The dossiq PR that seeds the DqTaak task depends on this one.
AI-assisted: written with Claude Code (claude-opus-5-5) and reviewed before submission.