Repository navigation
feat(example-sets): a fragment may give a resident a portal task - #4754
Merged
Merged
Conversation
A fragment's task may declare performerType: external with a party:<reference> assignee and uploadRules (required, maxFiles, maxSizeBytes, acceptedTypes). Install writes the rules as metadata.upload, where the portal task seam reads them, and raises the task as the fragment's app. The check refuses an external task that is not addressed to a party, one marked done by completedBy, upload rules on an internal task and an unknown upload rule. Assisted-by: ClaudeCode:claude-opus-5-5
rubenvdlinde
added a commit
to ConductionNL/portaliq
that referenced
this pull request
Oct 21, 2026
…ID (#1672) The Zuiddrecht set adds Sanne's open parking permit case (requester persoon-sanne via her BRP lookup) and on it an external portal task for party:<her uid>: "Stuur een kopie van uw ID-bewijs", at most two files, due in seven days, so Mijn taken opens the task page the TaakAfronden board draws. Needs openregister's external-party example set tasks (ConductionNL/openregister#4754). Assisted-by: ClaudeCode:claude-opus-5-5
Contributor
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ✅ | ||||
| test-l10n-parity | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 173/173 | |||
| npm | ✅ | ✅ 648/648 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ | ||||
| Newman | ❌ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-10-21 17:30 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR lets an example set seed a resident's portal task. Until now an example set could only seed tasks for its own Nextcloud accounts. The change is
example-set-external-party-tasks, and its spec is included.performerType: externalwith an assignee of the formparty:<reference>. Placeholders work in the reference, for exampleparty:{{cast:sanne.uid}}.uploadRules:required,maxFiles,maxSizeBytesandacceptedTypes. Install writes them asmetadata.upload, which is wherePortalTaskService::assertUploadConstraintsreads them.completedByuploadRuleson an internal taskExampleSetExternalTask, which keepsExampleSetTasksunder phpmd's complexity limit.Why: portaliq's TaakAfronden board ("Stuur een kopie van uw ID-bewijs") needs an open portal task for the example resident Sanne. The Zuiddrecht set adds that task in a portaliq PR that depends on this one.
Verified:
tests/Unit/Service/ExampleSet/passes: 146 tests, including the new external-task test and four new refusal cases.🤖 Generated with Claude Code