Dev - #122
Merged
Merged
Dev#122
Conversation
* Changed all status codes to the http.StatusCode equivalent. Also changed some 500s to 400s where appropriate to indicate user error (#85) * Started working on navbar * More progress * working theme selector * Eboard vote link appears on all pages * Started working on navbar * More progress * working theme selector * Rebase with dev * Finished rebasing with dev * Added favicon import * Misc other stuff, navbar is responsive now * larger nav title * Quorum text input, create page basically done * Finished poll creation page * Ranked choice poll page is done * Actually use the hidden template * changed icon * Fixed vote count on eboard votes * Added display of total votes submitted to results * small fixes * fixed spacing between buttons for eboard vote on mobile * poll title wrapping in a different place * Changed underline to bold * Capitalize description placeholder text --------- Co-authored-by: Noah Hanford <bigspaceships56@gmail.com>
* Fixed count of votes cast * Misc fixes
fix count reporting
* Limited poll title character length to 250 * Added backend validation for poll title length --------- Co-authored-by: Joseph Rosso <jdr1652@rit.edu>
* feat: update running env stuff * fix: empty username in the eligible voters
* feat: add ability hide votes if you cannot vote * fix: better for loop
shaeespring
reviewed
Oct 3, 2026
| return | ||
| } | ||
|
|
||
| // If title length exceeds 250 characters, return a bad request |
Contributor
There was a problem hiding this comment.
I think this error is impossible because of the max length placeholder, no?
Contributor
Author
There was a problem hiding this comment.
you could make an API request to do it
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix spelling, count reporting on results, limit poll title length, fix eligible vote counts, add option to hide votes from people who are ineligible to vote
Why
Dev
Test Plan
look at dev read the code idk
Env Vars
.env.example was created, but nothing was changed
Documentation
Yes
.envfiles was documentedChecklist