feat: add ability hide votes if you cannot vote - #121
Merged
Merged
Conversation
Contributor
Author
|
AGH it was so dumb |
Contributor
Author
|
now it's just coverage |
costowell
approved these changes
Oct 3, 2026
costowell
left a comment
costowell
left a comment
Contributor
There was a problem hiding this comment.
Looks pretty good overall, just small nits.
| polls := []*database.Poll{} | ||
|
|
||
| for i := range pollResults { | ||
| poll := pollResults[i] |
Contributor
There was a problem hiding this comment.
nit: you can do this
for i, poll := range pollResults {
|
BigSpaceships
added a commit
that referenced
this pull request
Oct 3, 2026
* Bootstrap 5 upgrade (#106) * Changed all status codes to the http.StatusCode equivalent. Also changed some 500s to 400s where appropriate to indicate user error (#85) * Started working on navbar * More progress * working theme selector * Eboard vote link appears on all pages * Started working on navbar * More progress * working theme selector * Rebase with dev * Finished rebasing with dev * Added favicon import * Misc other stuff, navbar is responsive now * larger nav title * Quorum text input, create page basically done * Finished poll creation page * Ranked choice poll page is done * Actually use the hidden template * changed icon * Fixed vote count on eboard votes * Added display of total votes submitted to results * small fixes * fixed spacing between buttons for eboard vote on mobile * poll title wrapping in a different place * Changed underline to bold * Capitalize description placeholder text --------- Co-authored-by: Noah Hanford <bigspaceships56@gmail.com> * Fixed count of votes cast (#108) * Fixed count of votes cast * Misc fixes * changed perferred to preferred lol * fix count reporting * Limited poll title character length to 250 (#115) * Limited poll title character length to 250 * Added backend validation for poll title length --------- Co-authored-by: Joseph Rosso <jdr1652@rit.edu> * fix: revert go version stuff * Fix empty voter in list and also moved documentation (#119) * feat: update running env stuff * fix: empty username in the eligible voters * feat: add ability hide votes if you cannot vote (#121) * feat: add ability hide votes if you cannot vote * fix: better for loop * fix: formatting --------- Co-authored-by: pikachu0542 <112343747+pikachu0542@users.noreply.github.com> Co-authored-by: aln730 <arnavgawas707@gmail.com> Co-authored-by: FlyingCowMaster <flyingcowmaster@gmail.com> Co-authored-by: Joseph Rosso <jdr1652@rit.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add option to hide votes from people who can't vote
Why
At 6 weeks we need secret votes and frosh shouldn't be able to see those
Test Plan
Locally, remove myself from eligible votes and see if I can see
Env Vars
Nope
Documentation
Nope
Checklist