People don't wanna vote and I don't get why - #120
Open
shaeespring wants to merge 3 commits into
Open
shaeespring wants to merge 3 commits into
shaeespring wants to merge 3 commits into
Conversation
shaeespring
force-pushed
the
public_shaming
branch
from
October 2, 2026 15:44
b4cceac to
a89ca96
Compare
Contributor
Author
|
It is not a new issue I'm pretty sure - I can fix with more functions but I don't think it's necessary |
costowell
previously approved these changes
Oct 3, 2026
| _, _, err = slackData.Client.PostMessage(slackData.AnnouncementsChannel, | ||
| slack.MsgOptionText("It has been past the default time required to vote on \""+poll.Title+ | ||
| "\" These people have not completed their responsibility as a Voting Member of House. \n"+ | ||
| strings.Join(notVotedString, ","), false)) |
| logging.Logger.WithFields(logrus.Fields{"method": "EvaluatePolls dm"}).Error(err) | ||
| continue | ||
| } | ||
| notVotedString = append(notVotedString, "<@"+user.SlackUID+">") |
Contributor
There was a problem hiding this comment.
nit: what if the user doesn't have a slack UID set?
costowell
reviewed
Oct 3, 2026
Comment on lines
+155
to
+159
| if user.SlackUID != "" { | ||
| notVotedString = append(notVotedString, "<@"+user.SlackUID+">") | ||
| } else { | ||
| notVotedString = append(notVotedString, user.Username) | ||
| } |
Contributor
There was a problem hiding this comment.
If the SlackUID is empty, I think the the slack message send will error first, and then this won't add the username.
Contributor
Author
There was a problem hiding this comment.
I think i fixed this? i don't know if I completely understand what you're asking for
shaeespring
force-pushed
the
public_shaming
branch
from
October 3, 2026 16:54
480c2c3 to
6a0a8bf
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Outs people in announcements if they don't vote
Why
It's Friday and we still haven't hit quorum on a vote released last Saturday
Test Plan
How do I test slack pinging in announcements? Do we first have to grant the bot privileges to?
Env Vars
No
Documentation
Erm.... no
Checklist