Add SoftInputKeyboardPopup and integrate keyboard handling for popups by FabriBertani · Pull Request #3117 · CommunityToolkit/Maui

FabriBertani · 2026-02-24T03:13:32Z

Description of Change

Fix added for the issue related to the OS keyboard overlapping the popup content on Android and iOS, with backward compatibility to .NET9
This fix behaves on both platforms the same as Android adjust resize input option, by pushing the popup content above the keyboard.

Linked Issues

Fixes [BUG] Software keyboard stays open when there is an Entry in a Popup and there is no easy way to close it on iOS #3058
Fixes [BUG] Popup with keyboard showing does no longer push content up #2698

PR Checklist

Has a linked Issue, and the Issue has been approved(bug) or Championed (feature/proposal)
Has tests (if omitted, state reason in description)
Has samples (if omitted, state reason in description)
Rebased on top of main at time of PR
Changes adhere to coding standard
Documentation created or updated: https://github.com/MicrosoftDocs/CommunityToolkit/pulls

Additional information

Tested on .Net Maui 9 and 10.
Android:
- 16
- 15
- 14
iOS:
- iPhone 15, iPhone 15 Pro, iPhone SE - 17.5
- iPhone 17 Pro - 26.2

pictos

Just a small adjustments, also can you remove the comments on code?

FabriBertani · 2026-02-25T00:23:57Z

Just a small adjustments, also can you remove the comments on code?

Just the comments or the summaries as well?

pictos · 2026-02-25T02:10:12Z

Just a small adjustments, also can you remove the comments on code?

Just the comments or the summaries as well?

just the comments, the summaries are fine

FabriBertani · 2026-02-25T09:58:55Z

done

…keyboard handling

pictos

Thanks for you contribution!
LGTM

yevgeny-sotnikov · 2026-09-28T16:16:17Z

@pictos when this PR will be merged? I have same issue and this block an ability to create popup with entry field at real app

pictos · 2026-09-29T16:07:12Z

@yevgeny-sotnikov I'm no longer in the core maintainer team, so I don't know about the schedule. Calling @CommunityToolkit/maui to see if they can help you

Copilot

Copilot review overview

🟡 Changes recommended

Platform lifecycle, state restoration, compatibility, and linked-issue requirements remain unresolved.

Review effort: Balanced
Findings: 1 · 3

Open (4)

Guard MAUI 10-only SafeArea APIs for MAUI 9 · New
Restore the previous soft-input mode when closing · New
Dispose existing keyboard observers before resubscribing · New
Enable popup keyboard dismissal on background tap · New

What changed in this PR

Attempts to prevent software keyboards from overlapping popup content on Android and iOS.

Changes:

Adds popup lifecycle hooks and keyboard-aware safe-area handling.
Implements platform-specific Android and iOS adjustments.
Adds a sample popup demonstrating keyboard controls.

File	Description
`PopupPage.shared.cs`	Configures soft-input safe-area behavior.
`Popup.shared.cs`	Adds platform lifecycle hooks.
`Popup.ios.cs`	Handles iOS keyboard notifications and insets.
`Popup.android.cs`	Changes Android soft-input resize mode.
`SoftInputKeyboardPopup.xaml.cs`	Implements the sample popup.
`SoftInputKeyboardPopup.xaml`	Defines keyboard-focused sample content.
`PopupsPage.xaml.cs`	Opens the new sample.
`PopupsPage.xaml`	Adds the sample navigation button.
`MauiProgram.cs`	Registers the sample popup.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

TheCodeTraveler · 2026-10-01T16:18:40Z

@FabriBertani Could you please address the CoPilot review comments?

FabriBertani · 2026-10-02T07:38:42Z

@FabriBertani Could you please address the CoPilot review comments?

Sure, I'll check them.

Copilot

🟡 Changes recommended

Platform lifecycle, iOS geometry, modal-page inheritance, and multi-window state issues can leave popups incorrectly positioned or keyboard settings unrestored.

8 open findings

Scope Android soft-input mode state per popup window · New
Handle keyboard frame changes to keep popup insets current · New
Resolve the popup controller from its native view responder chain · New
Calculate keyboard overlap without double-counting safe-area insets · New
Ensure popup teardown runs on every navigation removal path · New
Resolve the top modal before inheriting keyboard settings · New
Remove unnecessary null-forgiving operator · New
Replace misleading Try-pattern method with a void side-effect method · New

4 resolved since last review

Guard MAUI 10-only SafeArea APIs for MAUI 9
Enable popup keyboard dismissal on background tap
Dispose existing keyboard observers before resubscribing
Restore the previous soft-input mode when closing

🧠 Review effort: Balanced

+
+    partial void OnPlatformPopupOpened()
+    {
+        var android = Microsoft.Maui.Controls.Application.Current?.On<Microsoft.Maui.Controls.PlatformConfiguration.Android>();


+			return;
+		}
+
+		viewController ??= popupNativeView.Window?.RootViewController?.PresentedViewController;


+			return;
+		}
+
+		viewController.AdditionalSafeAreaInsets = new UIEdgeInsets(0, 0, args.FrameEnd.Height, 0);


 	{
 		Closed?.Invoke(this, EventArgs.Empty);
+
+		OnPlatformPopupClosed();


 		{
 			token.ThrowIfCancellationRequested();
+
+			TryInheritHideSoftInputFromPresentingPage(navigation.NavigationStack.LastOrDefault() ?? null);


+		shell.Items.Add(currentPage);
+
+		Assert.NotNull(Application.Current);
+		Application.Current!.Windows[0].Page = shell;


Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

# Conflicts: # samples/CommunityToolkit.Maui.Sample/MauiProgram.cs # samples/CommunityToolkit.Maui.Sample/Pages/Views/Popup/PopupsPage.xaml # samples/CommunityToolkit.Maui.Sample/Pages/Views/Popup/PopupsPage.xaml.cs

…hub.com/FabriBertani/Maui into bug/keybpard_overlapping_on_popup-issue

Add SoftInputKeyboardPopup and integrate keyboard handling for popups

d8323fb

pictos suggested changes Feb 24, 2026

View reviewed changes

Comment thread src/CommunityToolkit.Maui/Views/Popup/Popup.shared.cs Outdated

Comment thread src/CommunityToolkit.Maui/Views/Popup/Popup.shared.cs Outdated

Comment thread src/CommunityToolkit.Maui/Views/Popup/PopupPage.shared.cs Outdated

Implement keyboard handling for popups on iOS and Android

512d9c9

pictos reviewed Feb 25, 2026

View reviewed changes

Comment thread src/CommunityToolkit.Maui/Views/Popup/Popup.ios.cs

Add debug logging for view controller retrieval failure in iOS popup …

8beb2d2

…keyboard handling

pictos approved these changes Feb 25, 2026

View reviewed changes

dotnet-policy-service Bot added stale The author has not responded in over 30 days help wanted This proposal has been approved and is ready to be implemented labels Mar 31, 2026

TheCodeTraveler added the needs discussion Discuss it on the next Monthly standup label Sep 29, 2026

Merge branch 'main' into bug/keybpard_overlapping_on_popup-issue

a46ec69

TheCodeTraveler requested a balanced review from Copilot October 1, 2026 15:47

Copilot started reviewing on behalf of TheCodeTraveler October 1, 2026 15:47

View session

Copilot AI reviewed Oct 1, 2026

View reviewed changes

TheCodeTraveler removed help wanted This proposal has been approved and is ready to be implemented stale The author has not responded in over 30 days labels Oct 1, 2026

TheCodeTraveler self-assigned this Oct 1, 2026

TheCodeTraveler added 4 commits October 2, 2026 08:37

Merge branch 'main' into bug/keybpard_overlapping_on_popup-issue

e829cbf

Merge branch 'main' into bug/keybpard_overlapping_on_popup-issue

997f409

Properly dispose of previous Popup on OnPlatformPopupOpened

9c37b1d

Store + apply previousSoftInputMode

a52844f

TheCodeTraveler removed the needs discussion Discuss it on the next Monthly standup label Oct 8, 2026

Inherit parent's HideSoftInputOnTapped property

881ea0b

TheCodeTraveler requested a balanced review from Copilot October 8, 2026 23:13

Copilot started reviewing on behalf of TheCodeTraveler October 8, 2026 23:14

View session

Merge branch 'main' into bug/keybpard_overlapping_on_popup-issue

88f0000

Copilot AI reviewed Oct 8, 2026

View reviewed changes

TheCodeTraveler and others added 4 commits October 8, 2026 16:19

Change keyboard notification from WillShow to WillChangeFrame

09227e9

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Merge branch 'main' into bug/keybpard_overlapping_on_popup-issue

5e5fbf4

# Conflicts: # samples/CommunityToolkit.Maui.Sample/MauiProgram.cs # samples/CommunityToolkit.Maui.Sample/Pages/Views/Popup/PopupsPage.xaml # samples/CommunityToolkit.Maui.Sample/Pages/Views/Popup/PopupsPage.xaml.cs

Merge branch 'bug/keybpard_overlapping_on_popup-issue' of https://git…

a909dfd

…hub.com/FabriBertani/Maui into bug/keybpard_overlapping_on_popup-issue

Merge branch 'main' into bug/keybpard_overlapping_on_popup-issue

c64cd91

Conversation

FabriBertani commented Feb 24, 2026 • edited by TheCodeTraveler Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of Change

Linked Issues

PR Checklist

Additional information

Uh oh!

pictos left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

FabriBertani commented Feb 25, 2026

Uh oh!

pictos commented Feb 25, 2026

Uh oh!

FabriBertani commented Feb 25, 2026

Uh oh!

Uh oh!

pictos left a comment

Choose a reason for hiding this comment

Uh oh!

yevgeny-sotnikov commented Sep 28, 2026

Uh oh!

pictos commented Sep 29, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TheCodeTraveler commented Oct 1, 2026

Uh oh!

FabriBertani commented Oct 2, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

FabriBertani commented Feb 24, 2026 •

edited by TheCodeTraveler

Loading