Repository navigation
N°10196 - Fix TriggerOnAttachmentDownload - #1078
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The guard correctly prevents invalid attribute access without changing supported trigger behavior.
0 open findings
What changed in this PR
Fixes attachment-download triggers by avoiding access to the unsupported file_in_email attribute.
Changes:
- Checks attribute validity before reading
file_in_email. - Preserves email attachment behavior for create/delete triggers.
| File | Description |
|---|---|
datamodels/2.x/itop-attachments/src/Hook/EventListener.php |
Guards trigger attribute access. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
 |
Member
|
Just need to rebase onto the |
accognet
force-pushed
the
issue/10196-TriggerOnAttachmentDownload
branch
from
October 14, 2026 08:59
03eef0b to
b49b9e3
Compare
Molkobain
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
internal