N°10151 - Missing extension.xml in extension disturb setup by odain-cbd · Pull Request #1067 · Combodo/iTop

odain-cbd · 2026-10-06T06:07:23Z

No description provided.

Copilot

Copilot review overview

🟢 Approval recommended

The implementation and regression coverage are sound, with only a minor PHPDoc correction noted.

Review effort: Balanced
Findings: 1

Open (1)

Update ReadDir PHPDoc to document recursive traversal · New

What changed in this PR

Enables setup to discover extensions without extension.xml by scanning module definitions.

Changes:

Reuses recursive extension-map scanning for directory discovery.
Handles missing optional documentation URLs.
Adds coverage for XML and module-only extensions.

File	Description
`setup/extensionsmap.class.inc.php`	Adds scan-free maps and module-based discovery.
`tests/php-unit-tests/unitary-tests/setup/ExtensionsMapTest.php`	Tests XML and XML-less extension layouts.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

-				}
-			}
+		$oiTopExtensionsMap = new iTopExtensionsMap(bNoScan: true);
+		$oiTopExtensionsMap->ReadDir($sSearchDir, iTopExtension::SOURCE_REMOTE, bIsRootDir: true);


greptile-apps · 2026-10-06T06:10:25Z

Confidence Score: 0/5

[Medium impact] Adjusts extension scanning logic during setup.

The PR should not merge until the landing step preserves current modules and installed records, and extension discovery keeps the parent ID.

Findings

Current remote modules disappear ▶
Missing extensions go unnoticed ▶
Nested modules lose their parent ▶
Extension subdirectories can be skipped ▶
Nested XML can abort deployment ▶
Hidden modules become compilation choices ▶

Summary

The PR lets extension discovery recognize modules without extension.xml and changes which environment the audit landing step reads.

Directory listings now include extensions built from module files.
Upgrade setup reads the saved config and scans the build environment.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A["Keep current choices"] --> B["Landing step"]
  B --> C["Parent loads installed records"]
  C --> D["Replace map with build-directory scan"]
  D --> E["Build-only choices without installed records"]
  E --> F["Save selected modules"]
  F --> G["Audit copies files and compiles"]

_{Reviews (3) · Last reviewed commit: "N°10151 - fix broken extension with furt..." · Reviewed by Greptile}

greptile-apps · 2026-10-06T06:10:28Z

-				}
-			}
+		$oiTopExtensionsMap = new iTopExtensionsMap(bNoScan: true);
+		$oiTopExtensionsMap->ReadDir($sSearchDir, iTopExtension::SOURCE_REMOTE, bIsRootDir: true);


Extension subdirectories can be skipped If a -modules directory contains a module.*.php file alongside extension subdirectories, ReadDir returns after reading the module and never visits those subdirectories. The previous scan still read their extension.xml files. Their codes can therefore be missing when hub deployment determines which extensions to add, causing a selected extension to be omitted.

greptile-apps · 2026-10-06T06:10:28Z

-				}
-			}
+		$oiTopExtensionsMap = new iTopExtensionsMap(bNoScan: true);
+		$oiTopExtensionsMap->ReadDir($sSearchDir, iTopExtension::SOURCE_REMOTE, bIsRootDir: true);


Nested XML can abort deployment If a deeper directory contains a malformed extension.xml, the new recursive scan opens it and XMLParameters throws. Hub deployment does not handle that exception, so compilation aborts even though the previous immediate-child scan would not have read the file.

greptile-apps · 2026-10-06T06:31:27Z

+		foreach ($oiTopExtensionsMap->aExtensionsByCode as $sCode => $oExtension) {
+			/** @var iTopExtension $oExtension */
+			$aRes[$sCode] = $oExtension->sLabel;


Hidden modules become compilation choices When a module-only directory contains a module marked visible => false or auto_select, ReadDir adds it to the map but this loop returns its code without checking visibility. Hub compilation then treats that code as an added extension, despite the module being marked as one that should not be offered for selection.

Hipska · 2026-10-06T07:31:19Z

What is an extension disturb setup?

Hipska · 2026-10-12T05:54:05Z

@odain-cbd what is disturb setup?

iTop upgrade via designer failed with badly packaged extensions. there are further usecases covered and documented in current PR new test.

greptile-apps · 2026-10-12T05:56:25Z

 		// should be done at the end
 		parent::__construct($oWizard, $sCurrentState, false);
+
+		$this->oExtensionsMap = iTopExtensionsMap::GetExtensionsMap($this->oRuntimeEnv->GetBuildEnv());


Current remote modules disappear

When a user clicks “Keep current choices,” the build directory has not been prepared yet. This line scans data/production-build-modules rather than data/production-modules. If the build directory is absent, remote extensions disappear from the choices, and selected_modules is overwritten without their modules before the audit starts. The later file copy cannot restore that selection. Use the final environment for this shortcut, or prepare the build files before scanning them.

greptile-apps · 2026-10-12T05:56:25Z

 		// should be done at the end
 		parent::__construct($oWizard, $sCurrentState, false);
+
+		$this->oExtensionsMap = iTopExtensionsMap::GetExtensionsMap($this->oRuntimeEnv->GetBuildEnv());


Missing extensions go unnoticed

Replacing oExtensionsMap after the parent constructor drops the installed-extension records that LoadChoicesFromDatabase just loaded. Even when the build files exist, the replacement map has no record of installed extensions missing from disk. “Keep current choices” therefore skips the missing-extension check instead of returning the user to the choices screen. Load the database choices into the replacement map before using it.

greptile-apps · 2026-10-12T05:56:25Z


 			// First check if there is an extension.xml file in this directory
-			if (is_readable($sSearchDir.'/extension.xml')) {
+			if ($sParentExtensionId === null && is_readable($sSearchDir.'/extension.xml')) {


Nested modules lose their parent

Ignoring a child extension.xml leaves that call’s sExtensionId as null. If the child contains its modules in subdirectories, line 387 passes that null to them. They become standalone extensions instead of joining the outer extension. The outer extension can then have no modules, which makes setup throw “does not have any module associated.” Preserve the inherited parent ID when recursing through an ignored child definition.

greptile-apps · 2026-10-12T05:56:32Z

Want your agent to iterate on Greptile's feedback? Try greploops.

* N°10151 - Missing extension.xml in extension disturb setup * N°10151 - Missing extension.xml in extension disturb setup * N°10151 - add weird usecase with multi xml files in same extension * N°10151 - fix module not installed after MTP * N°10151 - fix broken extension with further extension.xml * N°10151 - code style

Hipska · 2026-10-13T07:08:34Z

@odain-cbd why do you ignore me like this? This is disturbing..

Edit: wait, are we now communicating by editing other people's comments? This is even more disturbing..

I still don't understand what you mean with "extension disturb setup" in your title?

Molkobain · 2026-10-13T07:36:39Z

@odain-cbd why do you ignore me like this? This is disturbing..

Edit: wait, are we now communicating by editing other people's comments? This is even more disturbing..

I still don't understand what you mean with "extension disturb setup" in your title?

I think/hope this is a mistake from @odain-cbd as his edit looks like a reply to your question. I'll talk about it with him this afternoon (he's off this morning)

odain-cbd · 2026-10-13T12:11:29Z

@odain-cbd why do you ignore me like this? This is disturbing..

Edit: wait, are we now communicating by editing other people's comments? This is even more disturbing..

I still don't understand what you mean with "extension disturb setup" in your title?

first i don't ignore you. editing your question was a mistake through github app. because indeed i was trying to answer... sorry for that.

my answer was:
iTop upgrade via designer failed with badly packaged extensions. there are further usecases covered and documented in current PR new test.

* N°10151 - Missing extension.xml in extension disturb setup * N°10151 - Missing extension.xml in extension disturb setup * N°10151 - add weird usecase with multi xml files in same extension * N°10151 - fix module not installed after MTP * N°10151 - fix broken extension with further extension.xml * N°10151 - code style

odain-cbd added 2 commits October 6, 2026 08:03

N°10151 - Missing extension.xml in extension disturb setup

39ee05a

N°10151 - Missing extension.xml in extension disturb setup

c249041

odain-cbd self-assigned this Oct 6, 2026

Copilot AI balanced review requested due to automatic review settings October 6, 2026 06:07

CombodoApplicationsAccount added the internal Work made by Combodo label Oct 6, 2026

odain-cbd requested review from Lenaick, Timmy38 and bdalsass October 6, 2026 06:07

Copilot started reviewing on behalf of odain-cbd October 6, 2026 06:07

View session

odain-cbd closed this Oct 6, 2026

Copilot AI reviewed Oct 6, 2026

View reviewed changes

Comment thread setup/extensionsmap.class.inc.php

}

}

$oiTopExtensionsMap = new iTopExtensionsMap(bNoScan: true);

$oiTopExtensionsMap->ReadDir($sSearchDir, iTopExtension::SOURCE_REMOTE, bIsRootDir: true);

greptile-apps Bot reviewed Oct 6, 2026

View reviewed changes

odain-cbd reopened this Oct 6, 2026

greptile-apps Bot reviewed Oct 6, 2026

View reviewed changes

odain-cbd added 3 commits October 6, 2026 16:39

N°10151 - add weird usecase with multi xml files in same extension

8c33ff1

N°10151 - fix module not installed after MTP

19b29fd

N°10151 - fix broken extension with further extension.xml

e54caa4

odain-cbd closed this Oct 8, 2026

odain-cbd reopened this Oct 12, 2026

greptile-apps Bot reviewed Oct 12, 2026

View reviewed changes

eespie self-requested a review October 12, 2026 08:45

eespie approved these changes Oct 12, 2026

View reviewed changes

N°10151 - code style

0ec7cbc

odain-cbd merged commit 62d7ca4 into develop Oct 12, 2026

odain-cbd deleted the issue/10151-mtp branch October 12, 2026 13:40

Conversation

odain-cbd commented Oct 6, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟢 Approval recommended

Uh oh!

greptile-apps Bot commented Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 0/5

Findings

Summary

Diagram

Uh oh!

greptile-apps Bot Oct 6, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Oct 6, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Oct 6, 2026

Choose a reason for hiding this comment

Uh oh!

Hipska commented Oct 6, 2026

Uh oh!

Hipska commented Oct 12, 2026 • edited by odain-cbd Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps Bot Oct 12, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Oct 12, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Oct 12, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot commented Oct 12, 2026

Uh oh!

Hipska commented Oct 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Molkobain commented Oct 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

odain-cbd commented Oct 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

greptile-apps Bot commented Oct 6, 2026 •

edited

Loading

Hipska commented Oct 12, 2026 •

edited by odain-cbd

Loading

Hipska commented Oct 13, 2026 •

edited

Loading

Molkobain commented Oct 13, 2026 •

edited

Loading