Repository navigation
Conversation
--- updated-dependencies: - dependency-name: xunit.analyzers dependency-version: 2.1.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…erTools.Tests/xunit.analyzers-2.1.0 Bump xunit.analyzers from 2.0.0 to 2.1.0
SkiaSharp and SkiaSharp.NativeAssets.Linux.NoDependencies must have the same version. Dependabot opened one PR per package (#241, #242), and each failed the Linux build until the other was merged. Codeuctivity.SkiaSharpCompare joins the group, and a 3 day cooldown on SkiaSharp gives it time to publish a release built against the new SkiaSharp.
Group SkiaSharp Dependabot updates into one PR
Bumps SkiaSharp from 4.152.0 to 4.153.1 Bumps SkiaSharp.NativeAssets.Linux.NoDependencies from 4.152.0 to 4.153.1 --- updated-dependencies: - dependency-name: SkiaSharp dependency-version: 4.153.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: skiasharp - dependency-name: SkiaSharp.NativeAssets.Linux.NoDependencies dependency-version: 4.153.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: skiasharp ... Signed-off-by: dependabot[bot] <support@github.com>
…erTools/skiasharp-09e6e903c2 Bump the skiasharp group with 2 updates
Bumps Codeuctivity.SkiaSharpCompare from 4.0.331 to 4.0.342 --- updated-dependencies: - dependency-name: Codeuctivity.SkiaSharpCompare dependency-version: 4.0.342 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: skiasharp ... Signed-off-by: dependabot[bot] <support@github.com>
…erTools.Tests/skiasharp-d732f7313e Bump the skiasharp group with 1 update
--- updated-dependencies: - dependency-name: xunit.analyzers dependency-version: 2.2.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…ream Fix UnicodeMapper's trimming of some whitespace that should be preserved
…erTools.Tests/xunit.analyzers-2.2.0 Bump xunit.analyzers from 2.1.0 to 2.2.0
Drop the direct xunit.analyzers reference: xunit.v3 already brings it in transitively with a matching minimum version, so the explicit pin only caused NU1605 downgrade errors when the two drifted. Bump xunit.v3 to 4.0.2 and add a Dependabot group so all xunit* packages update together.
Fix xunit.analyzers downgrade and group xunit Dependabot updates
There was a problem hiding this comment.
🟡 Changes recommended
NBSP replacements can corrupt text because splitting uses unnormalized runs, and the Dependabot cooldown can allow incompatible Compare-only updates.
2 open issues
What changed in this PR
This PR updates dependencies and Dependabot configuration, and adjusts UnicodeMapper to preserve non-breaking spaces and other Unicode whitespace when processing Word documents.
Changes:
- Group SkiaSharp-related updates and add a selective three-day cooldown.
- Refresh library, example, and test dependencies; remove the explicit
xunit.analyzersreference. - Restrict boundary trimming to XML whitespace and add regression tests and fixture documentation.
| File | Description |
|---|---|
TestFiles/UM-Whitespace.md |
Documents whitespace fixtures, Word observations, and reproduction steps. |
TestFiles/UM-Whitespace-Unicode-test.xml |
Adds 43 Unicode and XML whitespace cases. |
OpenXmlPowerToolsExamples/MarkupSimplifierApp/MarkupSimplifierApp.csproj |
Updates ConfigurationManager. |
OpenXmlPowerTools/UnicodeMapper.cs |
Preserves Unicode whitespace while trimming XML whitespace. |
OpenXmlPowerTools/OpenXmlPowerTools.csproj |
Updates SkiaSharp packages and the C# analyzer. |
OpenXmlPowerTools.Tests/UnicodeMapperTests.cs |
Adds NBSP round-trip coverage and strengthens fixture validation. |
OpenXmlPowerTools.Tests/OpenXmlRegexTests.cs |
Tests replacements spanning runs containing NBSPs. |
OpenXmlPowerTools.Tests/OpenXmlPowerTools.Tests.csproj |
Updates test dependencies and removes the explicit analyzer reference. |
.github/dependabot.yml |
Groups SkiaSharp-related packages and adds a selective cooldown. |
Review effort: Balanced
Comment on lines
+43
to
+45
| include: | ||
| - "SkiaSharp" | ||
| - "SkiaSharp.*" |
| ReadOnlySpan<char> span = preserve | ||
| ? text.AsSpan() | ||
| : text.AsSpan().Trim(); | ||
| : text.AsSpan().Trim(" \t\r\n"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.