Skip to content

London | 26-ITP-Sep | Sakiya Mayow | Sprint 3 | Dead code #1768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zakiaao-tech wants to merge 6 commits into
base: main
Choose a base branch
from
Open

London | 26-ITP-Sep | Sakiya Mayow | Sprint 3 | Dead code #1768

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3169807
changes let into const & changes name
zakiaao-tech Oct 31, 2026
e4dcab7
removed unnecessary variable & repeated console output
zakiaao-tech Oct 31, 2026
7b1e378
removed repeated testname & removed "printed" comment
zakiaao-tech Oct 31, 2026
b75c04e
removed unused code variable
zakiaao-tech Nov 1, 2026
1033fd3
removed unused code function
zakiaao-tech Nov 1, 2026
052914b
removed a comment(not part of dead code)
zakiaao-tech Nov 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions dead-code/exercise-1.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,13 @@
// Find the instances of unreachable and redundant code - remove them!
// The sayHello function should continue to work for any reasonable input it's given.

let testName = "Jerry";
const testName = "Aman";
const greeting = "hello";

function sayHello(greeting, name) {
const greetingStr = greeting + ", " + name + "!";
return `${greeting}, ${name}!`;

@dkrest1 dkrest1 Nov 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work cleaning up the code 👏

You've correctly removed the redundant variable and unreachable statement while keeping the sayHello() function working as expected.

One quick question to reinforce your understanding: why was the original console.log(greetingStr) unreachable?

Great progress overall!

console.log(greetingStr);
}

testName = "Aman";

const greetingMessage = sayHello(greeting, testName);

console.log(greetingMessage); // 'hello, Aman!'
console.log(greetingMessage);
8 changes: 2 additions & 6 deletions dead-code/exercise-2.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,8 @@
// The countAndCapitalisePets function should continue to work for any reasonable input it's given, and you shouldn't modify the pets variable.

const pets = ["parrot", "hamster", "horse", "dog", "hamster", "cat", "hamster"];
const capitalisedPets = pets.map((pet) => pet.toUpperCase());
const petsStartingWithH = pets.filter((pet) => pet[0] === "h");

@dkrest1 dkrest1 Nov 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job identifying and removing the unused capitalisedPets variable and logPets() function! 👏

You've kept the relevant code focused on the task.

function logPets(petsArr) {
petsArr.forEach((pet) => console.log(pet));
}
const petsStartingWithH = pets.filter((pet) => pet[0] === "h");

function countAndCapitalisePets(petsArr) {
const petCount = {};
Expand All @@ -25,4 +21,4 @@ function countAndCapitalisePets(petsArr) {

const countedPetsStartingWithH = countAndCapitalisePets(petsStartingWithH);

console.log(countedPetsStartingWithH); // { 'HAMSTER': 3, 'HORSE': 1 } <- Final console log
console.log(countedPetsStartingWithH);
Loading