Skip to content

London | 26-ITP-Sep | Mandip Sanger | Sprint 1 | formatAs12HourClock #1767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mandipsanger wants to merge 1 commit into
base: main
Choose a base branch
from
+25 −9
Open

London | 26-ITP-Sep | Mandip Sanger | Sprint 1 | formatAs12HourClock #1767

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions format-clock-edge-cases/timeConverter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,19 @@
function formatAs12HourClock(time) {
let hours = Number(time.slice(0, 2));
const minutes = time.slice(3);

const hours = Number(time.slice(0, 2));
const period = hours >= 12 ? "pm" : "am";

@Poonam-raj Poonam-raj Nov 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good use of the ternary operator!


if (hours > 12) {
return `${hours - 12}:00 pm`;
}
return `${time} am`;
if (hours === 0) {
hours = 12;
} else if (hours > 12) {
hours -= 12;
}

const formattedHours =
hours < 10 && hours !== 12 ? `0${hours}` : hours;

return `${formattedHours}:${minutes} ${period}`;
}

export {formatAs12HourClock};
export { formatAs12HourClock };
14 changes: 11 additions & 3 deletions format-clock-edge-cases/timeConverter.test.js
View file
Open in desktop

@Poonam-raj Poonam-raj Nov 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great test cases, good edge case work here. As a stretch - how could "bad" behaviours be tested here? What could go wrong with this function? How could we test that?

Original file line number Diff line number Diff line change
@@ -1,11 +1,19 @@
import {formatAs12HourClock} from "./timeConverter.js";
import { formatAs12HourClock } from "./timeConverter.js";
import assert from "node:assert";
import test from "node:test";

test("correctly convert time after 12:00", function(){
test("correctly convert time after 12:00", function () {
assert.equal(formatAs12HourClock("23:00"), "11:00 pm");
});

test("can correctly convert morning time", function() {
test("can correctly convert morning time", function () {
assert.equal(formatAs12HourClock("08:00"), "08:00 am");
});

test("converts midnight (00:00)", function () {
assert.equal(formatAs12HourClock("00:00"), "12:00 am");
});

test("converts noon (12:00)", function () {
assert.equal(formatAs12HourClock("12:00"), "12:00 pm");
});
Loading