Repository navigation
Manchester | 26-ITP-Sept | Rahana Suleiman | Sprint 2 | Implement and rewrite tests - #1702
Open
rahanasuleiman8-ship-it wants to merge 3 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
rahanasuleiman8-ship-it
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
rahanasuleiman8-ship-it
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
rahanasuleiman8-ship-it
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
rahanasuleiman8-ship-it
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
rahanasuleiman8-ship-it
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
rahanasuleiman8-ship-it
force-pushed
the
coursework/sprint-3-implement-and-rewrite
branch
from
October 14, 2026 23:35
27995e0 to
02b9cb7
Compare
rahanasuleiman8-ship-it
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
rahanasuleiman8-ship-it
force-pushed
the
coursework/sprint-3-implement-and-rewrite
branch
from
October 14, 2026 23:43
02b9cb7 to
6b39842
Compare
rahanasuleiman8-ship-it
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
rahanasuleiman8-ship-it
force-pushed
the
coursework/sprint-3-implement-and-rewrite
branch
from
October 14, 2026 23:56
6b39842 to
8529aeb
Compare
rahanasuleiman8-ship-it
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
rahanasuleiman8-ship-it
force-pushed
the
coursework/sprint-3-implement-and-rewrite
branch
from
October 15, 2026 00:01
8529aeb to
3e8c9c9
Compare
rahanasuleiman8-ship-it
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
rahanasuleiman8-ship-it
force-pushed
the
coursework/sprint-3-implement-and-rewrite
branch
from
October 15, 2026 00:06
5055a01 to
21ded3e
Compare
rahanasuleiman8-ship-it
added
the
Needs Review
webmonch
self-requested a review
October 19, 2026 22:06
webmonch
added
Review in progress
webmonch
reviewed
Oct 20, 2026
| }); | ||
|
|
||
| test("Arbitrary non-card string", () => { | ||
| assert.throws(() => getCardValue("invalid"), /Expected a number followed by a suit, but got "invalid"/, "Expected clear error"); |
There was a problem hiding this comment.
Is there a particular reason why you updated the provided test here?
webmonch
reviewed
Oct 20, 2026
|
|
||
| // Case 4: Invalid Cards | ||
| test("Should throw an error for arbitrary non-card strings", () => { | ||
| expect(() => getCardValue("invalid")).toThrow(); |
There was a problem hiding this comment.
Can you think of how these test that expect throw can be made more robust?
webmonch
reviewed
Oct 20, 2026
|
|
||
| // Right Angles (angle === 90°) | ||
| test("Classifies right angles", () => { | ||
| assert.equal(getAngleType(90), "Right angle"); |
There was a problem hiding this comment.
Can you spot another test that checks the same thing here?
webmonch
reviewed
Oct 20, 2026
| expect(getAngleType(1)).toEqual("Acute angle"); | ||
| expect(getAngleType(45)).toEqual("Acute angle"); | ||
| expect(getAngleType(89)).toEqual("Acute angle"); | ||
| expect(getAngleType(89.9)).toEqual("Acute angle"); |
There was a problem hiding this comment.
Nice idea to test decimals close to the boundary! Is there a particular reason to replace 89 rather than keep both values?
webmonch
reviewed
Oct 20, 2026
| throw new Error(`Expected a string, but got ${typeof card}`); | ||
| } | ||
|
|
||
| const cardRegex = /^(10|[2-9]|[AJQK])([♠♥♦♣])$/; |
|
Good job! Very clean implementations and thorough test coverage, especially around the boundaries. Apart from a couple of small issues with the provided tests and formatting - everything looks solid! |
webmonch
added
Reviewed
rahanasuleiman8-ship-it
added
the
Needs Review
rahanasuleiman8-ship-it
added
Reviewed
Author
|
Hi @webmonch , thank you so much for the helpful review and feedback! I have addressed the points you raised: getCardValue & getAngleType tests: Refactored the test assertions to ensure they are robust and cleaner, while keeping the boundary value checks thorough. Provided tests: Restored and respected the originally provided test cases as requested. The updates have been pushed and the PR is ready for another look. Thanks again for your time!" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Task code
CYF-1059
Changelist
This PR implements the getAngleType, isProperFraction, and getCardValue functions alongside comprehensive unit test suites using both node:test and Jest to cover all standard, edge, and invalid input cases.