Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion Sprint-1/fix/median.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,27 @@
// or contains values that aren't numbers (the function is expected to throw - see the tests).

function calculateMedian(list) {
if (!Array.isArray(list)) {
throw new Error("calculateMedian requires an array of numbers");
}
if (list.length === 0) {
throw new Error("calculateMedian requires a non-empty array");
}
const middleIndex = Math.floor(list.length / 2);
const median = list.splice(middleIndex, 1)[0];
let median;
const copyList = list.slice();
copyList.sort((a, b) => a - b);

for (const elements of copyList) {
if (typeof elements !== "number") {
throw new Error("calculateMedian requires an array of numbers");
}
}
if (copyList.length % 2 === 0) {
median = (copyList[middleIndex] + copyList[middleIndex - 1]) / 2;
} else {
median = copyList[middleIndex];
}
return median;
}

Expand Down
15 changes: 14 additions & 1 deletion Sprint-1/implement/dedupe.js
Original file line number Diff line number Diff line change
@@ -1 +1,14 @@
function dedupe() {}
function dedupe(elements) {
if (elements.length === 0) {
return [];
}
let newArray = [];
for (const items of elements) {
if (!newArray.includes(items)) {
newArray.push(items);
}
}
return newArray;
}

module.exports = dedupe;
17 changes: 15 additions & 2 deletions Sprint-1/implement/dedupe.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,26 @@ E.g. dedupe([1, 2, 1]) returns [1, 2]
// Given an empty array
// When passed to the dedupe function
// Then it should return an empty array
test.todo("given an empty array, it returns an empty array");
test("given an empty array, it returns an empty array", () => {
expect(dedupe([])).toEqual([]);
});

// Given an array with no duplicates
// When passed to the dedupe function
// Then it should return a copy of the original array
test("given an array with no duplicates it returns copy of original array", () => {
expect(dedupe([1, 2, 3, 4])).toEqual([1, 2, 3, 4]);
});

// Given an array of strings or numbers
// When passed to the dedupe function
// Then it should return a new array with duplicates removed while preserving the
// Then it should return a new array with duplicates removed while preserving the
// first occurrence of each element from the original array.
test("given an array with duplicates of strings and numbers it returns first occurrence of each element", () => {
expect(dedupe([1, "ball", "ball", 3, 1, "egg"])).toEqual([
1,
"ball",
3,
"egg",
]);
});
14 changes: 13 additions & 1 deletion Sprint-1/implement/describe-median.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,18 @@ function calculateMedian(list) {
}

// Implement this function. See describe-median.test.js for the acceptance criteria.
function describeMedian(list) {}
function describeMedian(list) {
try {
const median = calculateMedian(list);
return `The median is ${median}`;
} catch (error) {
if (error.message === "calculateMedian requires a non-empty array") {
return `Could not calculate a median: ${error.message}`;
}
if (error.message === "calculateMedian requires an array of numbers") {
return `Could not calculate a median: ${error.message}`;
}
}
}

module.exports = describeMedian;
14 changes: 13 additions & 1 deletion Sprint-1/implement/describe-median.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,24 @@ const describeMedian = require("./describe-median.js");
// When passed to describeMedian
// Then it should return "The median is " followed by the median
// Delete this test.todo and replace it with a test.
test.todo('given [1, 2, 3], returns "The median is 2"');
test('given [1, 2, 3], returns "The median is 2"', () => {
expect(describeMedian([1, 2, 3])).toEqual("The median is 2");
});

// Given an empty array
// When passed to describeMedian
// Then it should return "Could not calculate a median: calculateMedian requires a non-empty array"
test('given [], returns "Could not calculate a median: calculateMedian requires a non-empty array"', () => {
expect(describeMedian([])).toEqual(
"Could not calculate a median: calculateMedian requires a non-empty array"
);
});

// Given something that isn't an array of numbers, e.g. "banana"
// When passed to describeMedian
// Then it should return "Could not calculate a median: calculateMedian requires an array of numbers"
test('given not an array, returns "Could not calculate a median: calculateMedian requires an array of numbers"', () => {
expect(describeMedian("banana")).toEqual(
"Could not calculate a median: calculateMedian requires an array of numbers"
);
});
21 changes: 21 additions & 0 deletions Sprint-1/implement/max.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,25 @@
function findMax(elements) {
if (!Array.isArray(elements)) {
throw new Error("findMax requires an array of numbers");
}
for (const items of elements) {
if (typeof items !== "number") {
throw new Error("findMax requires an array of numbers");
}
}
if (elements.length === 0) {
return -Infinity;
}
if (elements.length === 1) {
return elements[0];
}
let max = elements[0];
for (const items of elements) {
if (items > max) {
max = items;
}
}
return max;
}

module.exports = findMax;
26 changes: 25 additions & 1 deletion Sprint-1/implement/max.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,28 +16,52 @@ const findMax = require("./max.js");
// When passed to the max function
// Then it should return -Infinity
// Delete this test.todo and replace it with a test.
test.todo("given an empty array, returns -Infinity");
test("given an empty array, returns -Infinity", () => {
expect(findMax([])).toEqual(-Infinity);
});

// Given an array with one number
// When passed to the max function
// Then it should return that number
test("given one element number in an array, returns that number", () => {
expect(findMax([23])).toEqual(23);
});

// Given an array with both positive and negative numbers
// When passed to the max function
// Then it should return the largest number overall
test("returns the largest number in an array", () => {
expect(findMax([2, -4, 0, -3, 5])).toEqual(5);
});

// Given an array with just negative numbers
// When passed to the max function
// Then it should return the closest one to zero
test("returns the closest number to zero in an array", () => {
expect(findMax([-22, -4, -2, -3, -5])).toEqual(-2);
});

// Given an array with decimal numbers
// When passed to the max function
// Then it should return the largest decimal number
test("returns the largest decimal number in an array", () => {
expect(findMax([0.34, 6.3, 2.2, 7.1, 5.0])).toEqual(7.1);
});

// Given an array containing a value that isn't a number
// When passed to the max function
// Then it should throw Error("findMax requires an array of numbers")
test("throws for an array mixing numbers and strings", () => {
expect(() => findMax([2, -4, "hi", -3, 5])).toThrow(
new Error("findMax requires an array of numbers")
);
});

// Given something that isn't an array at all, such as "hey", 42 or no argument
// When passed to the max function
// Then it should throw Error("findMax requires an array of numbers")
test("throws when not given an array type", () => {
expect(() => findMax("hey")).toThrow(
new Error("findMax requires an array of numbers")
);
});
20 changes: 19 additions & 1 deletion Sprint-1/implement/mean.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,21 @@
function calculateMean(list) {}
function calculateMean(list) {
if (list === undefined) {
throw new Error("calculateMean requires an array of numbers");
}
if (!Array.isArray(list)) {
throw new Error("calculateMean requires an array of numbers");
}
if (list.length === 0) {
throw new Error("calculateMean requires a non-empty array");
}
let total = 0;
for (const elements of list) {
if (typeof elements !== "number") {
throw new Error("calculateMean requires an array of numbers");
}
total = total + elements;
}
return total / list.length;
}

module.exports = calculateMean;
30 changes: 29 additions & 1 deletion Sprint-1/implement/mean.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,28 +23,56 @@ const calculateMean = require("./mean.js");
// When passed to calculateMean
// Then it should return their mean
// Delete this test.todo and replace it with a test.
test.todo("given [1, 2, 6], returns 3");
test("given [1, 2, 6], returns 3", () => {
expect(calculateMean([1, 2, 6])).toEqual(3);
});

// Given an array with a single number
// When passed to calculateMean
// Then it should return that number
test("given [1], returns 1", () => {
expect(calculateMean([1])).toEqual(1);
});

// Given an array containing negative or decimal numbers
// When passed to calculateMean
// Then it should return the correct mean
test("given [1, 2, 6], returns 3", () => {
expect(calculateMean([-2, 2.8, 4.6])).toBeCloseTo(1.8);
});

// Given an empty array
// When passed to calculateMean
// Then it should throw Error("calculateMean requires a non-empty array")
test("throws an error when given empty array", () => {
expect(() => {
calculateMean([]);
}).toThrow(new Error("calculateMean requires a non-empty array"));
});

// Given a value that isn't an array, e.g. "banana", 42, null or {}
// When passed to calculateMean
// Then it should throw Error("calculateMean requires an array of numbers")
test("throws an error when not given an array", () => {
expect(() => {
calculateMean("hello");
}).toThrow(new Error("calculateMean requires an array of numbers"));
});

// Given no argument at all
// When passed to calculateMean
// Then it should throw Error("calculateMean requires an array of numbers")
test("throws an error when no argument is given", () => {
expect(() => {
calculateMean();
}).toThrow(new Error("calculateMean requires an array of numbers"));
});

// Given an array containing a non-number value, e.g. [1, "2", 3]
// When passed to calculateMean
// Then it should throw Error("calculateMean requires an array of numbers")
test("throws an error when an array contains non-number values", () => {
expect(() => {
calculateMean([1, "2", 3]);
}).toThrow(new Error("calculateMean requires an array of numbers"));
});
17 changes: 17 additions & 0 deletions Sprint-1/implement/sum.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,21 @@
function sum(elements) {
if (!Array.isArray(elements)) {
throw new Error("sum requires an array of numbers");
}
for (const items of elements) {
if (typeof items !== "number") {
throw new Error("sum requires an array of numbers");
}
}
if (elements.length === 0) {
return 0;
}

let sum = 0;
for (const items of elements) {
sum = sum + items;
}
return sum;
}

module.exports = sum;
23 changes: 22 additions & 1 deletion Sprint-1/implement/sum.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,24 +13,45 @@ const sum = require("./sum.js");
// Given an empty array
// When passed to the sum function
// Then it should return 0
test.todo("given an empty array, returns 0")
test("given an empty array, returns 0", () => {
expect(sum([])).toEqual(0);
});

// Given an array with just one number
// When passed to the sum function
// Then it should return that number
test("given one element in an array, returns that number", () => {
expect(sum([7])).toEqual(7);
});

// Given an array containing negative numbers
// When passed to the sum function
// Then it should still return the correct total sum
test("given negative elements in an array, returns sum of negative numbers", () => {
expect(sum([-1, -4, -7, -3])).toEqual(-15);
});

// Given an array with decimal/float numbers
// When passed to the sum function
// Then it should return the correct total sum
test("given decimal elements in an array, returns sum of decimal numbers", () => {
expect(sum([1.0, 4.4, 2.7, 0.6])).toBeCloseTo(8.7);
});

// Given an array containing a value that isn't a number
// When passed to the sum function
// Then it should throw Error("sum requires an array of numbers")
test("throws error when elements of an array are not numbers", () => {
expect(() => {
sum(["hi", 7, "hello", "10"]);
}).toThrow(new Error("sum requires an array of numbers"));
});

// Given something that isn't an array at all, such as "hey", 42 or no argument
// When passed to the sum function
// Then it should throw Error("sum requires an array of numbers")
test("throws error when parameter is not an array", () => {
expect(() => {
sum("hello");
}).toThrow(new Error("sum requires an array of numbers"));
});
3 changes: 1 addition & 2 deletions Sprint-1/refactor/includes.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
// Refactor the implementation of includes to use a for...of loop

function includes(list, target) {
for (let index = 0; index < list.length; index++) {
const element = list[index];
for (const element of list) {
if (element === target) {
return true;
}
Expand Down
Loading