Repository navigation
Complete Philadelphia property-tax benefit library - #541
Merged
prestoncabe merged 13 commits intoOct 6, 2026
Merged
prestoncabe merged 13 commits into
prestoncabe merged 13 commits into
Conversation
Implement Low-Income Tax Freeze, LOOP, and RETIP with reusable income, age, ownership, assessment, abatement, and payment-plan checks. Publish builder-compatible compositions for all six benefits, document policy inputs and sources, and cover eligibility boundaries with Bruno tests. Treat an explicitly empty enrollment list as no enrollments while preserving unknown for unanswered inputs.
Keep failed loads from throwing during editor rendering. Show a return link and retry action for stale screener URLs, and test both recovery paths.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The city requires Homestead recipients to remove that exemption when they enroll in LOOP, so current enrollment should not make them ineligible. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Low-Income Tax Freeze limit covers the applicant's and spouse's income, not the household total that LOOP and RETIP use, so it reads a new applicantAndSpouseIncome field. Marriage now comes from relationships via the shared spouse id BKM, matching the age checks, and the unused simpleChecks.isMarried field is removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Example payloads used 42 for every number, so household-size checks returned null and the endpoint smoke test was loosened to accept that. Generate size fields as 1 and restore the non-null checkResult assertion. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Show the loading state while retrying a failed load, keep the loaded editor open when a later refetch fails, and stop refetches from replacing unsaved form edits with the server copy. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The library now treats an empty enrollment list as not enrolled in any program, so the seed form and README no longer warn that None of these leaves enrollment unknown. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Navigating away clears screenerId while the editor is still mounted, so the title read of the loaded screener threw and blocked navigation, and the resource refetched with no ID. Skip fetching without an ID and read the title defensively. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Add the imported spouse and income helper shapes and connect their knowledge requirements to the output decisions. Clean DMN validation now reports no diagram warnings.
prestoncabe
deleted the
270-add-library-benefits-and-eligibility-checks-for-property-tax-benefits
branch
October 6, 2026 19:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The library lacked three of Philadelphia's six supported property-tax benefits. Add Low-Income Tax Freeze, LOOP, and the Real Estate Tax Installment Plan (RETIP), with the reusable and composite checks needed to import their eligibility rules into a screener. All six benefits now expose callable checks and builder-compatible OpenAPI compositions.
Closes #270
Closes #387
Closes #389
Closes #537
Verification
git diff --checkpassed.A clean library build reports zero diagram-validation warnings. Imported helper-function shapes, requirement coverage, and edge geometry were also checked.
Documentation impact