Repository navigation
Add CCCORELIB_USE_SYSTEM_NANOFLANN to use an installed nanoflann - #141
Open
Tobias-Fischer wants to merge 1 commit into
Open
Tobias-Fischer wants to merge 1 commit into
Tobias-Fischer wants to merge 1 commit into
Conversation
find_package(nanoflann) instead of the bundled extern/nanoflann submodule; off by default.
11 tasks done
Member
|
Thanks, maybe require nanoflann < 2.0 as we haven't evaluated nanoflann 2+ yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
CCCORELIB_USE_SYSTEM_NANOFLANN(defaultOFF). It uses an installed nanoflann (find_package(nanoflann)) instead of theextern/nanoflannsubmodule, as distributions and conda-forge prefer.Tested in conda builds of CloudCompare v2.14.beta2 against conda-forge's nanoflann 2.0.1 on macOS arm64/x86_64, Linux and Windows.
Written with an AI tool (Claude Code).
🤖 Generated with Claude Code