Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #918 +/- ##
============================================
+ Coverage 34.27% 35.18% +0.90%
- Complexity 7011 7156 +145
============================================
Files 298 298
Lines 27325 27700 +375
============================================
+ Hits 9367 9746 +379
+ Misses 17958 17954 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Two credential-redaction gaps allow hoster and embedded site access keys to be stored in diagnostic reports.
2 open issues
What changed in this PR
Extends the existing connection-reporting system to track API calls separately from Anti-Spam moderation requests.
Changes:
- Records API connection failures with request sanitization and separate statistics and retention limits.
- Adds report-source and API-method fields to storage.
- Displays API request types and statistics in settings and email reports.
| File | Description |
|---|---|
| tests/ApbctWP/TestConnectionReports.php | Adds API-reporting checks and cleanup; excluded from review. |
| lib/Cleantalk/Common/Schema.php | Adds source and method-name columns. |
| lib/Cleantalk/ApbctWP/PluginSettingsPage/SummaryAndSupportRenderer.php | Allows paragraphs in report HTML. |
| lib/Cleantalk/ApbctWP/ConnectionReports.php | Implements API reporting, sanitization, statistics, and display. |
| lib/Cleantalk/ApbctWP/API.php | Passes API results to connection reporting. |
Review effort: Balanced
| */ | ||
| private $api_sensitive_keys = array( | ||
| 'auth_key', | ||
| 'api_key', |
Comment on lines
+700
to
+703
| if (in_array(strtolower((string)$key), $this->api_sensitive_keys, true)) { | ||
| $result[$key] = '***'; | ||
| continue; | ||
| } |
svedge
approved these changes
Oct 27, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://app.doboard.com/1/task/55510