Repository navigation
Conversation
#477) Paste, drop and the file picker refuse a 9th screenshot, an image over 8 MiB, or one that would push attachments past the 16 MiB body budget, with a visible message naming the refused files. Send re-checks the whole body and refuses with a message rather than getting a 413; an oversized auto-captured canvas is skipped with a note in the toast. MAX_SHOTS, MAX_SHOT_BYTES and MAX_BODY mirror etchy-server.py, checked by a unit test. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Review finding: an image added during the request was cleared by the post-send reset without being sent or reported. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #477. Stacked on #475.
The demo feedback widget had no client-side limits, so a 9th screenshot, an image over 8 MiB, or a body over 16 MiB got a 413 from the feedback server (#411).
MAX_SHOTS(8), overMAX_SHOT_BYTES(8 MiB), or that would push attachments past theMAX_BODY(16 MiB) budget. A visible#etfb-errmessage (role=alert) names each refused file and the reason. Non-images that are dropped or picked are now reported too. Slots are reserved while files are read, so parallel reads can't go over a limit.MAX_BODY, nothing is sent and the user sees a message. Send also waits for any reads still in progress. If the auto-captured canvas is too large, it is skipped and the toast says so.MAX_*values in the JS mirroretchy-server.py. A unit test checks that they match.No CHANGELOG entry (deploy-only).