Repository navigation
security(#228): replace x-api-key on sporty-sync with Supabase JWT - #243
Merged
Merged
Conversation
…se JWT The POST /api/sporty-sync HTTP trigger was authenticated via a shared x-api-key checked against SPORTY_SYNC_API_KEY. While VITE_SPORTY_SYNC_API_KEY was not in CI secrets, the pattern was fragile and the key could leak if accidentally added. The /api/claude endpoint already handles this correctly with verifySupabaseJwt + X-Supabase-Token; this commit applies the same pattern to the sporty-sync trigger. The /api/sporty-health monitoring endpoint retains x-api-key — it is only called by external monitoring tools, never by the frontend. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Updates to Preview Branch (security/228-sporty-sync-jwt-auth) ↗︎
Tasks are run on every commit but only new migration files are pushed.
❌ Branch Error • Fri, 15 May 2026 20:54:26 UTC View logs for this Workflow Run ↗︎. |
Keep both imports: verifySupabaseJwt from claudeUtils.js (this branch) and normalizeName from sportyUtils.js (merged from master). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-island-090dfd003-243.westeurope.7.azurestaticapps.net |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
x-api-key/VITE_SPORTY_SYNC_API_KEYauth pattern onPOST /api/sporty-syncwith the same Supabase JWT verification already used by/api/claudeX-Supabase-Token(Azure SWA hijacks theAuthorizationheader — this is a documented pitfall in CLAUDE.md)Home.jsxDEV sync button now fetches the Supabase session and sends the token — no moreVITE_env var needed in the frontend/api/sporty-healthmonitoring endpoint retainsx-api-key(external monitoring tool, not frontend)local.settings.json.exampleupdated with a note clarifyingSPORTY_SYNC_API_KEYis health-endpoint-onlyTest plan
npm test)swa start), trigger sync with DEV button — should succeed with a valid sessionPOST /api/sporty-syncwithout a JWT returns 401GET /api/sporty-healthstill requiresx-api-key(unchanged)Closes #228
🤖 Generated with Claude Code