Repository navigation
Optimize CI/CD workflows and expand test coverage - #226
Merged
Merged
Conversation
Closes #218 — rename workflow files to readable names (ci.yml, cleanup-staging.yml) Closes #219 — harden ci.yml: concurrency cancel, timeout-minutes, correct Vite cache key, output_location comment, remove lfs:false Closes #220 — move npm audit to weekly audit.yml; simplify lint step in ci.yml Closes #221 — fix stale claudeUtils test description ("two model IDs" → one) Closes #222 — extract normalizeName to sportyUtils.js and add 5 unit tests Closes #223 — tag production deploys with GitHub environment (production/preview) Closes #224 — split ci.yml into validate (lint+test) and deploy (build+SWA) jobs Closes #225 — document dev branch deploy behavior with inline comment https://claude.ai/code/session_0111FuxhPFLJ8f6AtZ1Wk4fe
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-island-090dfd003-226.westeurope.7.azurestaticapps.net |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$(cat <<'EOF'
Summary
ci.ymlandcleanup-staging.yml(As a developer I want workflow files to have readable names so I can instantly understand what each one does #218)ci.yml: concurrency cancel-in-progress,timeout-minutes: 15, correct Vite cache key (deps only, not all ofsrc/**),output_locationcomment, removes redundantlfs: false(As a developer I want the CI workflow hardened with concurrency control, timeout, and a correct Vite cache key so runs are fast and reliable #219)npm auditout of the PR gate into a weeklyaudit.ymlschedule; simplifies lint step to a singlenpm run lint(As a developer I want npm audit moved to a weekly scheduled workflow so it stops blocking PRs for unfixable transitive vulnerabilities #220)claudeUtils.test.js("two model IDs" when there is one) (As a developer I want the stale test description in claudeUtils.test.js fixed so the test suite accurately describes what it covers #221)normalizeNamefromsportySync.jsintosportyUtils.js(no Azure SDK dep) and adds 5 unit tests covering straight quotes, curly quotes, plain names, fully-annotated names, and whitespace trimming (As a developer I want normalizeName in sportySync.js covered by tests so quote-stripping regressions are caught automatically #222)environment: production; PR/dev deploys getenvironment: preview(As a developer I want the production deploy job tagged with a GitHub environment so deployment history and protection rules are available #223)ci.ymlinto avalidatejob (lint + test) and adeployjob (needs: validate) so lint/test failures give instant feedback as a separate status check without waiting for a build (As a developer I want ci.yml split into a validate job and a deploy job so test failures give instant feedback without waiting for a build #224)devbranch deploy behaviour with an inline comment explaining it intentionally shares the production slot (As a developer I want the dev branch trigger in ci.yml clarified or removed so it is clear what environment a direct push to dev deploys to #225)Test plan
npm testinapp/) — 5 newnormalizeNametests addedvalidateanddeployappear as separate status checks on this PRdeployjob (skipped, not failed)master, the deployment appears under theproductionenvironment in the repository's Environments tab (create the environment in Settings → Environments if it doesn't exist yet)audit.ymlworkflow can be triggered manually viaworkflow_dispatchto confirm it runs cleanhttps://claude.ai/code/session_0111FuxhPFLJ8f6AtZ1Wk4fe
EOF
)
Generated by Claude Code