You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
As a developer I want the pull_request closed type removed from ci.yml so CI deploy runs are not silently cancelled on PR merge #258
ci.yml lists closed in its pull_request.types, but both jobs skip on a closed event (validate has an explicit if guard, deploy needs validate). The problem: both the pull_request: closed event and the push-to-master event share the same concurrency group (CI-<workflow>-refs/heads/master). When a PR is merged, the closed event fires first, starts a CI run, then the push event fires and — because cancel-in-progress: true — cancels the already-running push/deploy job. The staging cleanup is handled separately by cleanup-staging.yml and does not need closed in ci.yml at all. Confirmed by the cancelled deploy run on PR #257 merge.
Priority
High
Acceptance criteria
closed removed from pull_request.types in ci.yml
Next PR merge produces a single CI run that completes successfully (no cancellation)
cleanup-staging.yml still fires and closes the staging environment on PR merge
Out of scope
Consolidating cleanup logic into ci.yml — cleanup-staging.yml handles this correctly already
Activity
test(#258): guard package.json version against CHANGELOG drift
fix(#258): remove closed PR type from ci.yml + bump version to 1.5.13 (…