Repository navigation
feat(blocksync): preserve continuous mode for Cronos v1.8 - #2
Merged
Merged
Conversation
Signed-off-by: lihe <he.li@debank.com>
|
🔒 WARNING: unsigned commits detected This pull request contains 1 commit(s) without a verified signature. How to fix:
Docs: https://docs.github.com/authentication/managing-commit-signature-verification Unsigned commits:
|
Signed-off-by: lihe <he.li@debank.com>
|
🔒 WARNING: unsigned commits detected This pull request contains 2 commit(s) without a verified signature. How to fix:
Docs: https://docs.github.com/authentication/managing-commit-signature-verification Unsigned commits: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cronos v1.8 writers need continuous block sync on the v0.39 release line. Preserve that mode on the exact Cronos baseline
14b7b93046e3, with validator/adaptive-mode rejection and peer-height metrics.Fix the mempool broadcast goroutine leak exposed by continuous sync: disconnected peers now exit the sync wait, and peer/reactor shutdown also ends the peer-state wait. This releases the goroutine references without requiring a switch to consensus. Continuous sync and normal transaction propagation semantics are preserved.
Validation with Go 1.25.11:
go test ./config ./blocksync ./nodepassed for the continuous-sync port.go test ./mempool -count=1 -timeout=5mpassed.-race -count=20, including 20 disconnect cycles per run.go vet ./mempool, golangci-lint v2.11.3 on./mempool/..., formatting and diff checks passed.The deterministic sync-release/disconnect race and saturated gossip semaphore paths have not been exercised by the new tests. The pre-existing semaphore loop does not respond to stopping only the reactor while its peer remains running. No production rollout is included.
I hereby certify that my contribution is in accordance with the Developer Certificate of Origin (https://developercertificate.org/).