Repository navigation
✨ feat(connections): Open SQLite file… from the welcome pane (#117) - #150
Merged
Merged
Conversation
file_pick("sqlite") filters SQLite databases (*.sqlite, *.sqlite3, *.db,
*.db3) first, then All files. picker_spec now returns a list of filters.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
sqliteFileDraft(path) is a new SQLite connection on the file, named after it. ConnectionForm's draft prop starts a new connection from it, as unsaved edits: nothing is stored before Save or Connect. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…lette The picker (SQLite purpose) fills a new connection's form on the chosen file, named after it; Connect saves and opens it like any new connection, so nothing is written before the user's action. Cancelling the picker does nothing; a picker failure shows on the connections screen; a file that does not open shows the usual connect error over the form. The palette's Open SQLite file… asks about a form's unsaved edits first. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #117
Summary
Open SQLite file… in the welcome pane, as the spec's welcome actions list it. It was left out in Task 8 because the app had no SQLite file picker.
file_pickgets a"sqlite"purpose. The dialog shows "SQLite databases" (sqlite,sqlite3,db,db3) as its default filter, then "All files".picker_specnow returns a list of filters. Tested.app.db), so an unsaved temporary connection would be a large refactor.core:default(the dialog plugin was already used).Known limit: with Tauri's default GTK3 dialog, "All files" is
*.*, so files without an extension aren't listed. They can still be opened by typing their path.How it was tested
pnpm test:rust(with the test databases) was not run locally, because Docker is off on this machine. CI runs it. The only Rust change is incommands.rs.Manual check list
.sqlite,.sqlite3,.dband.db3files. "All files" is in the filter list.demo.sqlite(frompnpm demo:db, or any SQLite file).x.db, then Connect. The connect error shows above the form, and the form stays.>then "Open SQLite file…". The picker opens; after a pick you land on the pre-filled form on the connections screen.*.*). Typing its path (Ctrl+L) still works.Checklist
pnpm testgreenpnpm lintgreen (tsc + clippy-D warnings)pnpm test:rustgreen (CI)src/lib/strings.ts<emoji> <type>(<scope>): <description>🤖 Generated with Claude Code