Repository navigation
✨ feat(editor): row details panel for SQL tab results, read-only (#115) - #142
Merged
Merged
Conversation
…tails; the panel takes a SQL result DataGrid: onSelectRow for grids without editing, a new result starts with no selection, and grid.rowDetails is matched in the grid's own keydown (with Space). RowDetailPanel: object, info and the edit callbacks may be absent (read-only), a cut value that cannot be loaded says so, fields keyed by position too (#115). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
#115) The results grid reports its selected row; the window's one panel shows it on the right of the editor and the results, following the Result N on screen (Message view, a run going: No row selected). Space / Ctrl+Space in the results grid and the toolbar button toggle it; the button is soft-disabled on a SQL tab whose run has no result set. Ctrl+Space in the editor stays completion. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…+click Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…ndment #115 also replaces "button disabled" Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #115
Summary
The row detail panel from Task 7 now also works on SQL tab results, read-only.
grid.rowDetailskeeps itstableTabscope, and no id was added. The grid reads the shortcut in its own keydown, asgrid.copyCellsalready does in the results grid. In a table tab the grid now takes Ctrl+Space itself, so the window binding can't toggle twice. That window binding is unchanged: it still toggles from anywhere outside a text field.softDisabledwith its tooltip, and the switch keeps its value.Follow-up from the review: #141. A
grid.rowDetailsrebinding that collides with a SQL-tab key (query.save) is not flagged by Settings;grid.copyCellshas the same exposure.No Rust change.
How it was tested
Manual check list (light and dark)
select 1 as id, '{"a":[1,2]}'::jsonb as doc, null as n, repeat('x', 100000) as big;.docis indented,nis an empty box with the NULL placeholder, andbigshows its start, "…" and "Only the start of this value was loaded."Checklist
pnpm testgreenpnpm lintgreen (tsc; no Rust change, clippy in CI)pnpm test:rustgreen (not applicable: nosrc-tauri/change)src/lib/strings.ts<emoji> <type>(<scope>): <description>🤖 Generated with Claude Code