Repository navigation
✨ feat(connections): Escape closes the connection form (#118) - #140
Merged
Merged
Conversation
Escape in the form, or with the focus on the page, returns to the list through the same "Discard changes to this connection?" question as ←. A dialog, a shown tooltip, an IME composition or a field's suggestion list keeps its own Escape; the form hidden behind a workspace never reacts. The URL import dialog gives the focus back to its button. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…e form (#118) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…e in a confirmation (#118) The URL import, host key, secret and import dialogs prevent the default of their Escape, as ConfirmDialog does: in WebKit a dialog unmounted between listeners would otherwise let the connection form behind close on the same press. ConfirmDialog ignores Escape's repeats, so a held key no longer opens and cancels the discard question at once. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
… app modals over the form (#118) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…118) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #118
Summary
Escape closes the connection form, like ←. It goes through App's existing
closeForm, so a form with edits first asks "Discard changes to this connection?". When it closes, the focus goes back to the selected row, or to the search box if no row is selected.ConnectionForm, registered only while the form is on screen. A form hidden behind a workspace has no listener. No keymap action is added: this is the form's own fixed Escape, like a dialog's.isModalOpen);defaultPrevented);preventDefault): Import from URL, the host-key and secret prompts, and Import. So one press never closes both a dialog and the form, whatever order the listeners run in.ConfirmDialogignores Escape repeats: a held key acts once. Holding Escape on an edited form opens the question and keeps it open.defaultPrevented;ConfirmDialog: repeats.No Rust change.
How it was tested
Manual check list
Each closes the clean form.
~/.ssh/configaliases: the same as step 9 in SSH host.Checklist
pnpm testgreenpnpm lintgreen (tsc; no Rust change, clippy in CI)pnpm test:rustgreen (not applicable: nosrc-tauri/change)src/lib/strings.ts<emoji> <type>(<scope>): <description>🤖 Generated with Claude Code