Repository navigation
fix(import): [develop] log each template error correctly - #856
Merged
Merged
Conversation
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
TheWitness
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The template import error loop logs the previous success message instead of its current error, and an errors-only import can reference an unset variable. Log $error for each entry.
Fixes #757. This plugin fix targets develop and remains compatible with its supported Cacti 1.2.x and develop installations.
Validation: the regression executes the production error loop through the existing logging recorder; it fails before and passes after the fix. Related threshold/environment tests and the manifest check pass. The complete native suite has an existing macOS failure because its successful-command fixture expects /bin/true, which is absent here; this is not a full-suite green claim. No database, mail server or device was contacted.