Repository navigation
bug: pass bool (not int) to api_plugin_register_hook() $enable - #852
Merged
Merged
Conversation
Cacti 1.3 types api_plugin_register_hook() 5th arg as bool enable. These calls passed int 1, which only coerces while the file lacks declare(strict_types=1); pass true so they stay type-correct. php -l clean.
TheWitness
requested review from
bmfmancini and
xmacan
and
a balanced review from Copilot
October 8, 2026 18:48
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Seventeen remaining hook registrations still pass '1' instead of a boolean.
1 open finding
What changed in this PR
Updates hook registration arguments for Cacti 1.3’s strict boolean signature.
Changes:
- Replaces three integer enable flags with
true. - Documents the compatibility fix.
| File | Description |
|---|---|
setup.php |
Uses a boolean hook enable flag. |
includes/database.php |
Updates two hook registrations. |
CHANGELOG.md |
Records the compatibility fix. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…de sites Convert the 17 other api_plugin_register_hook() 5th arguments in includes/database.php from the string '1' to boolean true so the upgrade/re-registration paths are strict_types-safe against Cacti develop's bool \ signature.
…enable-bool # Conflicts: # CHANGELOG.md
xmacan
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cacti 1.3 (develop) types the 5th argument of
api_plugin_register_hook()as a strictbool $enable(lib/plugins.php). This plugin's hook (re-)registration calls passed the integer1instead oftrue.Today that only coerces because the calling file does not declare
strict_types. The momentdeclare(strict_types=1)is added to that file (an ongoing hardening direction across the plugin fleet), those calls would throw:which fatals the plugin management page on load — exactly what happened in
plugin_routerconfigs(fixed in Cacti/plugin_routerconfigs#188).Change
Pass
trueinstead of1(andfalsefor any0) at everyapi_plugin_register_hook()call site. Type-only correctness fix — no behavior change.php -lclean.api_plugin_register_realm()is not affected (its trailing argument is typedmixed, notbool).