feature: make the tags graph drilldown button an Enable/Disable Tags toggle

[TheWitness]

Summary

Reworks this plugin's graph drilldown action button from a static link into a stateful Enable Tags / Disable Tags toggle, mirroring the Thold VRULE toggle pattern.

Cacti's graph action (drilldown) menu now renders each registered button's title as a visible text label. Rather than a static Tags link to the tags page, the button now toggles whether this plugin's tag legend lines are drawn on graphs, and its label reflects the current session state.

Changes

• include/functions.php - plugin_tags_graph_button(): now flips a session draw-state (sess_config_array['tags_draw']) via a tags_draw request var and renders Enable Tags / Disable Tags (two complete i18n strings, not an appended On/Off fragment) with a toggle URL. Any existing tags_draw parameter is stripped first so a click never duplicates it.
• include/functions.php - plugin_tags_rrd_graph_graph_options(): skips drawing the tag legend lines when the toggle is off. Tags are drawn by default, preserving prior behaviour.
• tests/Unit/TagsGraphButtonTest.php - rewritten to cover every toggle branch, the URL dedup (including the first-parameter case), and the legend-draw gate; full standard GPL header.
• tests/bootstrap-unit.php - add an isset_request_var stub (function_exists-guarded).
• locales/po/cacti.pot - regenerated for the new Enable Tags / Disable Tags strings.
• CHANGELOG.md - entry under develop.

Note on scope

This supersedes the original "shorten the title to Tags" scope: per maintainer direction the button becomes a state toggle instead of a navigation link. The Tags management page remains reachable from the console menu.

Testing

• php -l - clean on all changed PHP files.
• php tests/bin/check-i18n-pot.php origin/develop - OK (pot included).
• Unit tests drive all toggle states, URL dedup across parameter positions, and the legend gate.

[Copilot]

🟡 Changes recommended

The new PHP test file omits the repository-required standard GPL license header.

1 open finding

• Use the standard GPL header in the new PHP file · New

What changed in this PR

Shortens the graph drilldown label to “Tags” and adds corresponding coverage and localization updates.

Changes:

• Replaces the verbose graph-button title.
• Adds unit coverage and regenerates the gettext template.
• Documents the change in the changelog.

File	Description
include/​functions.php	Shortens the graph-button title.
tests/​Unit/​TagsGraphButtonTest.php	Tests rendered title, icon, and link.
locales/​po/​cacti.pot	Updates translation references.
CHANGELOG.md	Records the label change.

🧠 Review effort: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

🟡 Changes recommended

The implementation contradicts the stated scope and generates conflicting query parameters in a common navigation path.

2 open findings

• First query parameter leaves duplicate tags_draw values · New
• Tags drilldown behavior contradicts requested scoped title change · New

1 resolved since last review

• Use the standard GPL header in the new PHP file

🧠 Review effort: Balanced

[Copilot]

🔵 Needs a closer look

The new test file still lacks the required complete GPL header.

0 open findings

2 resolved since last review

• Tags drilldown behavior contradicts requested scoped title change
• First query parameter leaves duplicate tags_draw values

Previously missed (1)

In code that hasn't changed since last review

Restore complete standard GPL header in new test

tests/​Unit/​TagsGraphButtonTest.php:15

The new test still omits the warranty and Cacti Group attribution paragraphs from the required standard PHP GPL header; compare setup.php:2-23 and tests/Unit/CspNonceTest.php:2-23. Replace this abbreviated block with the complete repository header.

🧠 Review effort: Balanced