Skip to content

Codebase quality sweep - #418

Merged
bmfmancini merged 16 commits into
developfrom
codebase_quality_sweep
Oct 16, 2026
Merged

bmfmancini merged 16 commits into
developfrom
codebase_quality_sweep

style: Fix SonarCloud line-length and label accessibility findings on…

f055a56
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Oct 16, 2026 in 35s

Annotations

Check warning on line 129 in tests/Unit/DashboardWriteFailureTest.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

2 statements were found on this line. Reformat the code to have only one statement per line.

See more on https://sonarcloud.io/project/issues?id=Cacti_plugin_syslog&issues=AaFGU80bmECgjoAZMieV&open=AaFGU80bmECgjoAZMieV&pullRequest=418

Check warning on line 38 in tests/regression/quality_must_fix_database_test.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

2 statements were found on this line. Reformat the code to have only one statement per line.

See more on https://sonarcloud.io/project/issues?id=Cacti_plugin_syslog&issues=AaFGU9DmmECgjoAZMifv&open=AaFGU9DmmECgjoAZMifv&pullRequest=418

Check warning on line 36 in tests/Unit/RemoteSchemaBootstrapTest.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Split this 156 characters long line (which is greater than 120 authorized).

See more on https://sonarcloud.io/project/issues?id=Cacti_plugin_syslog&issues=AaFGU84EmECgjoAZMiee&open=AaFGU84EmECgjoAZMiee&pullRequest=418

Check warning on line 787 in tests/bootstrap-unit.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move this open curly brace to the beginning of the next line.

See more on https://sonarcloud.io/project/issues?id=Cacti_plugin_syslog&issues=AaFGU88ImECgjoAZMiep&open=AaFGU88ImECgjoAZMiep&pullRequest=418

Check warning on line 194 in includes/processing.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Align all arguments in this list at column "6".

See more on https://sonarcloud.io/project/issues?id=Cacti_plugin_syslog&issues=AaFGW_mKTyNwBWW51gji&open=AaFGW_mKTyNwBWW51gji&pullRequest=418

Check warning on line 783 in tests/bootstrap-unit.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move this open curly brace to the beginning of the next line.

See more on https://sonarcloud.io/project/issues?id=Cacti_plugin_syslog&issues=AaFGU88ImECgjoAZMieo&open=AaFGU88ImECgjoAZMieo&pullRequest=418

Check warning on line 791 in tests/bootstrap-unit.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename function "input_validate_input_number" to match the regular expression ^[a-z][a-zA-Z0-9]*$.

See more on https://sonarcloud.io/project/issues?id=Cacti_plugin_syslog&issues=AaFGU88ImECgjoAZMieu&open=AaFGU88ImECgjoAZMieu&pullRequest=418

Check warning on line 157 in tests/regression/quality_must_fix_database_test.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

2 statements were found on this line. Reformat the code to have only one statement per line.

See more on https://sonarcloud.io/project/issues?id=Cacti_plugin_syslog&issues=AaFGU9DmmECgjoAZMif3&open=AaFGU9DmmECgjoAZMif3&pullRequest=418

Check warning on line 42 in tests/regression/quality_must_fix_database_test.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move this open curly brace to the beginning of the next line.

See more on https://sonarcloud.io/project/issues?id=Cacti_plugin_syslog&issues=AaFGU9DmmECgjoAZMiff&open=AaFGU9DmmECgjoAZMiff&pullRequest=418

Check warning on line 85 in tests/regression/quality_must_fix_database_test.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Split this 143 characters long line (which is greater than 120 authorized).

See more on https://sonarcloud.io/project/issues?id=Cacti_plugin_syslog&issues=AaFGU9DmmECgjoAZMie-&open=AaFGU9DmmECgjoAZMie-&pullRequest=418

Check warning on line 29 in tests/Unit/DashboardWriteFailureTest.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move this open curly brace to the beginning of the next line.

See more on https://sonarcloud.io/project/issues?id=Cacti_plugin_syslog&issues=AaFGU80bmECgjoAZMieR&open=AaFGU80bmECgjoAZMieR&pullRequest=418

Check warning on line 1266 in lib/syslog_dashboard.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move this open curly brace to the beginning of the next line.

See more on https://sonarcloud.io/project/issues?id=Cacti_plugin_syslog&issues=AaFGU9X1mECgjoAZMigO&open=AaFGU9X1mECgjoAZMigO&pullRequest=418

Check warning on line 36 in tests/Unit/DashboardWriteFailureTest.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Either split this list into multiple lines, aligned at column "5" or put all arguments on line "36".

See more on https://sonarcloud.io/project/issues?id=Cacti_plugin_syslog&issues=AaFGU80bmECgjoAZMieS&open=AaFGU80bmECgjoAZMieS&pullRequest=418

Check warning on line 38 in tests/Unit/DashboardWriteFailureTest.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move the closing parenthesis on the next line.

See more on https://sonarcloud.io/project/issues?id=Cacti_plugin_syslog&issues=AaFGU80bmECgjoAZMieT&open=AaFGU80bmECgjoAZMieT&pullRequest=418

Check warning on line 132 in tests/regression/quality_must_fix_database_test.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Split this 203 characters long line (which is greater than 120 authorized).

See more on https://sonarcloud.io/project/issues?id=Cacti_plugin_syslog&issues=AaFGU9DmmECgjoAZMifO&open=AaFGU9DmmECgjoAZMifO&pullRequest=418

Check warning on line 134 in includes/processing.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Align all arguments in this list at column "5".

See more on https://sonarcloud.io/project/issues?id=Cacti_plugin_syslog&issues=AaFGW_mKTyNwBWW51gjg&open=AaFGW_mKTyNwBWW51gjg&pullRequest=418

Check warning on line 44 in tests/regression/quality_must_fix_database_test.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename function "get_nfilter_request_var" to match the regular expression ^[a-z][a-zA-Z0-9]*$.

See more on https://sonarcloud.io/project/issues?id=Cacti_plugin_syslog&issues=AaFGU9DmmECgjoAZMifs&open=AaFGU9DmmECgjoAZMifs&pullRequest=418

Check warning on line 0 in tests/Unit/RemoteUninstallTest.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace all tab characters in this file by sequences of white-spaces.

See more on https://sonarcloud.io/project/issues?id=Cacti_plugin_syslog&issues=AaFGU8wzmECgjoAZMieE&open=AaFGU8wzmECgjoAZMieE&pullRequest=418

Check warning on line 47 in tests/Unit/RemoteSchemaBootstrapTest.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

2 statements were found on this line. Reformat the code to have only one statement per line.

See more on https://sonarcloud.io/project/issues?id=Cacti_plugin_syslog&issues=AaFGU84EmECgjoAZMiej&open=AaFGU84EmECgjoAZMiej&pullRequest=418

Check warning on line 1147 in lib/syslog_dashboard.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Either split this list into multiple lines, aligned at column "7" or put all arguments on line "1145".

See more on https://sonarcloud.io/project/issues?id=Cacti_plugin_syslog&issues=AaFGU9X1mECgjoAZMigc&open=AaFGU9X1mECgjoAZMigc&pullRequest=418

Check warning on line 154 in tests/regression/quality_must_fix_database_test.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Split this 147 characters long line (which is greater than 120 authorized).

See more on https://sonarcloud.io/project/issues?id=Cacti_plugin_syslog&issues=AaFGU9DmmECgjoAZMifX&open=AaFGU9DmmECgjoAZMifX&pullRequest=418

Check warning on line 16 in tests/Security/ReplicationCreateSqlTest.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename function "syslog_test_snapshot_setup" to match the regular expression ^[a-z][a-zA-Z0-9]*$.

See more on https://sonarcloud.io/project/issues?id=Cacti_plugin_syslog&issues=AaFGU8_tmECgjoAZMie0&open=AaFGU8_tmECgjoAZMie0&pullRequest=418

Check warning on line 43 in tests/regression/quality_must_fix_database_test.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move this open curly brace to the beginning of the next line.

See more on https://sonarcloud.io/project/issues?id=Cacti_plugin_syslog&issues=AaFGU9DmmECgjoAZMifg&open=AaFGU9DmmECgjoAZMifg&pullRequest=418

Check warning on line 61 in tests/Unit/QueryBuilderGuardTest.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Split this 163 characters long line (which is greater than 120 authorized).

See more on https://sonarcloud.io/project/issues?id=Cacti_plugin_syslog&issues=AaFGU8womECgjoAZMid_&open=AaFGU8womECgjoAZMid_&pullRequest=418

Check warning on line 37 in tests/regression/quality_must_fix_database_test.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

2 statements were found on this line. Reformat the code to have only one statement per line.

See more on https://sonarcloud.io/project/issues?id=Cacti_plugin_syslog&issues=AaFGU9DmmECgjoAZMifu&open=AaFGU9DmmECgjoAZMifu&pullRequest=418