Repository navigation
Syslog Status: auto-refresh interval dropdown + refresh glyph - #403
Merged
Merged
Conversation
Add an auto-refresh interval dropdown and a manual refresh glyph to the Syslog Status toolbar (mirroring the intropage refresh concept); the interval persists through the page's auto-reload and the refresh glyphs spin while their cards reload. Also switch the Status refresh glyphs from the unrendered Font Awesome 4 fa-refresh alias to fa-sync-alt so they show under the bundled Font Awesome 6.
TheWitness
requested review from
bmfmancini and
xmacan
and
a balanced review from Copilot
October 9, 2026 21:29
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new controls cause horizontal overflow on narrow viewports because the toolbar cannot wrap.
1 open finding
What changed in this PR
Adds configurable and manual refresh controls to the Syslog Status page.
Changes:
- Adds a persistent auto-refresh interval selector.
- Adds spinning manual and per-card refresh glyphs.
- Updates refresh icons for Font Awesome 6 compatibility.
| File | Description |
|---|---|
syslog.php |
Renders refresh controls and updated icons. |
js/functions.js |
Handles interval changes and card refreshes. |
css/search.css |
Styles the new toolbar controls. |
CHANGELOG.md |
Documents the feature and icon fix. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
bmfmancini
previously approved these changes
Oct 9, 2026
Address PR review: the toolbar was a non-wrapping flex row, so the auto-refresh group beside the 220px add-card select overflowed horizontally on narrow/mobile widths. flex-wrap lets the refresh group drop to its own row.
bmfmancini
approved these changes
Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Brings the intropage "refresh" concept to the Syslog Status page:
fa-spin) while the cards reload; the per-card refresh glyph spins the same way.fa-refreshalias, so the Status tools now usefa-sync-alt.Related Issue
N/A — small UX follow-up to the Syslog Status cards.
Motivation and Context
The Status tab had no way to control its auto-refresh cadence, and the per-card refresh glyph was invisible because
fa-refreshis not a rendered class in the Font Awesome 6 build that Cacti ships.How Has This Been Tested?
Loaded the Syslog Status tab on light and dark themes: the interval dropdown and refresh glyph appear on the right of the toolbar, the glyph spins while cards reload, and changing the interval persists across auto-reloads.
php -lclean onsyslog.php.Types of changes
Checklist: