Repository navigation
fix incorrect include - #134
Merged
Merged
Conversation
TheWitness
previously approved these changes
Oct 15, 2026
The maint include used file_exists(require_once(...)), which evaluates require_once first (including the file as a side effect, or fataling when it is absent) and then tests file_exists() on its return value. Replace it with a straightforward file_exists() probe that prefers the relocated plugins/maint/includes/functions.php and falls back to the legacy plugins/maint/functions.php. Also add servcheck_process.php to the patch-coverage unmeasured allowlist: it is a CLI/daemon poller entry point (shebang, chdir + include, pcntl signal handling) that cannot be loaded into the isolated unit process, so it can never appear in the Clover report. This clears the failing 'changed production PHP files are not measured or allowlisted' gate. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
bmfmancini
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we moved it