Skip to content

Use a CSS class for the status legend footer instead of inline styles #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheWitness merged 3 commits into from
Oct 8, 2026
Merged

Use a CSS class for the status legend footer instead of inline styles #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6c438b6
Pin status legend to the bottom of the page (match MacTrack)
TheWitness Oct 7, 2026
f51f695
Use a CSS class for the legend footer instead of inline styles
TheWitness Oct 7, 2026
97c8f19
ci: allowlist servcheck_test.php in the patch-coverage gate
TheWitness Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions css/common.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,14 @@
width: 100%;
}

/* Keeps the legend centered beneath the results in normal document flow, so it
never overlays the bottom pagination or bulk-action controls. */
.servcheck_legend_footer {
display: table;
width: 100%;
margin: 8px auto 0;
}

.servcheck_legend .servcheck_legend_item {
text-align: center;
white-space: nowrap;
Expand Down
2 changes: 2 additions & 0 deletions servcheck_test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1365,7 +1365,9 @@ function data_list(): void {
print $nav;
}

print '<div class="center servcheck_legend_footer">';
servcheck_legend();
print '</div>';

draw_actions_dropdown($servcheck_actions_menu, 1);

Expand Down
3 changes: 3 additions & 0 deletions tests/bin/patch-coverage.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,9 @@ function changed_lines($base_ref) {
* Empty by default; add entries per repository as the need arises.
*/
$unmeasured_allowlist = [
// Web page controller: chdir()s and includes auth.php at the top level, so it
// cannot be loaded into the isolated unit process and is absent from Clover.
'servcheck_test.php',
];
$unmeasured = array_values(array_diff(array_keys($changed), array_keys($measured)));
$unexpected_unmeasured = array_values(array_diff($unmeasured, $unmeasured_allowlist));
Expand Down
Loading