Repository navigation
Add per-theme CSS for all remaining Cacti themes - #392
Merged
Merged
Conversation
MacTrack shipped dedicated stylesheets for dark, deepness, modern, paper-plane, paw and sunrise, but the Cacti develop theme set also includes cacti, carrot, hollyberry, raspberry (light) and midwinter (dark). For those themes mactrack_page_head() fell back to the generic mactrack.css, so the Issues/dot1x status pills and the status legend were not tuned to the theme and could be hard to read. This adds a dedicated, theme-appropriate stylesheet for each of the remaining themes: - cacti, carrot, hollyberry, raspberry: light-theme variant (based on modern.css) with the MacTrack action-icon accents retinted to each theme's signature colour. - midwinter: dark-theme variant (based on deepness.css) with cool blue action-icon accents. The semantic status colours for the pills and legend (green up, red errors/down, etc.) stay consistent across themes for legibility; only the theme-branded chrome changes per theme.
TheWitness
requested review from
bmfmancini and
xmacan
and
a balanced review from Copilot
October 14, 2026 13:22
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Several icon colors fail contrast requirements, Midwinter lacks light-mode styling, and the change is absent from the changelog.
13 open findings
What changed in this PR
Adds dedicated MacTrack styling for the five remaining Cacti themes.
Changes:
- Adds four light-theme stylesheets with branded icon accents.
- Adds Midwinter styling based on the dark Deepness palette.
| File | Description |
|---|---|
css/cacti.css |
Adds Cacti theme styling. |
css/carrot.css |
Adds Carrot theme styling. |
css/hollyberry.css |
Adds Hollyberry theme styling. |
css/raspberry.css |
Adds Raspberry theme styling. |
css/midwinter.css |
Adds Midwinter theme styling. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
xmacan
previously approved these changes
Oct 14, 2026
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Midwinter’s light-mode row selectors override pill and legend text colors, producing insufficient contrast.
1 open finding
13 resolved since last review
🧠 Review effort: Balanced
…e is legible and pills/legend keep white text
xmacan
approved these changes
Oct 14, 2026
xmacan
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ensures every Cacti (develop) theme has its own MacTrack stylesheet, so the Interfaces "Issues" pills, the dot1x status pill and the status legend are legible and theme-appropriate in all themes — not just the six that already had dedicated files.
Previously MacTrack shipped per-theme CSS for
dark,deepness,modern,paper-plane,pawandsunrise. The Cacti develop theme set also includescacti,carrot,hollyberry,raspberry(light) andmidwinter(dark). For those,mactrack_page_head()fell back to the genericmactrack.css, which is not tuned to the theme.Changes
New
css/<theme>.cssfor each remaining theme:The semantic status colours for the pills/legend (green = up, red = errors/down, gold = discards, grey = graphless, orange = unaliased) stay consistent across every theme for readability; only the theme-branded chrome (the
.mt*action-icon accents) changes per theme.Verification
Each new stylesheet was rendered against the actual Cacti develop theme stylesheet with a realistic list table (active + inactive pill mixes and the legend footer) and visually confirmed legible. The four light themes were pixel-verified;
midwinteris the verifieddeepnessdark template with only the action-icon accents retinted.