Repository navigation
mactrack: shorten interface status pill labels to single words - #389
Merged
bmfmancini merged 2 commits intoOct 10, 2026
Merged
Conversation
Interface Up/No Alias/Errors Present/Discards Present/No Graphs/Interface Down become Up/Alias/Errors/Discards/Graphs so the per-row Issues pills fit better; footer legend and Status filter stay in sync. Regenerated cacti.pot.
TheWitness
requested review from
bmfmancini and
xmacan
and
a balanced review from Copilot
October 9, 2026 21:38
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
“Alias” and “Graphs” misleadingly represent missing aliases and graphs, and the stated footer interaction is not implemented.
3 open findings
What changed in this PR
Shortens interface-status labels to reduce pill width across the Interfaces view.
Changes:
- Shortens shared status and footer labels.
- Regenerates the gettext template.
| File | Description |
|---|---|
lib/mactrack_functions.php |
Updates shared status labels. |
mactrack_view_interfaces.php |
Updates footer legend labels. |
locales/po/cacti.pot |
Refreshes translations. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Address PR review: 'Alias'/'Graphs' read as the opposite of the int_up_wo_alias/int_no_graph absence conditions they filter on. Use concise negatives so pills, footer legend and the Status filter keep their meaning. Regenerated cacti.pot.
bmfmancini
approved these changes
Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shorten the interface status chip labels on the MacTrack Interfaces view
from descriptive phrases to concise words so the per-row Issues pills fit
better:
Interface Up -> Up
No Alias -> Unaliased
Errors Present -> Errors
Discards Present -> Discards
No Graphs -> Graphless
Interface Down -> Down
The
int_up_wo_aliasandint_no_graphclasses are absence conditions(interface is up but has no alias / has no graphs), so their labels stay
semantically negative ("Unaliased"/"Graphless") rather than reading as
their opposite.
The labels live in the shared
mactrack_interface_status_legend()helper(drives the Issues pills and the multi-select Status filter) and in the
duplicated footer-legend array, both updated to stay in sync.
Status actions are driven from the per-row Issues pills (which toggle the
corresponding status in the multi-select Status filter) and from the
Status drop-down itself. The footer legend is a non-interactive colour
key for those same statuses.
locales/po/cacti.potregenerated withlocales/build_gettext.sh(xgettext) to track the changed translatable strings.