Repository navigation
Panel reload glyph: use fa-sync-alt and spin while reloading - #422
Merged
Merged
Conversation
Replace the "Reload Panel" header glyph's fa-retweet icon with the proper refresh icon (fa-sync-alt) and spin it (fa-spin) while the panel reloads. The reload render path is an AJAX endpoint that exits, so the single changed line is marked @codeCoverageIgnore (unreachable from the unit suite), consistent with the allowlisted entry points.
TheWitness
requested review from
bmfmancini and
xmacan
and
a balanced review from Copilot
October 9, 2026 21:32
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Failed requests leave the icon spinning indefinitely, and the PHP change bypasses required coverage.
2 open findings
What changed in this PR
Updates panel reload feedback with a clearer refresh icon and loading animation.
Changes:
- Replaces
fa-retweetwithfa-sync-alt. - Spins the icon during reload.
- Documents the UX change.
| File | Description |
|---|---|
includes/intropage.js |
Adds reload animation. |
includes/functions.php |
Renders the refresh glyph. |
CHANGELOG.md |
Records the UX fix. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…d button Address PR review: (1) reload_panel()'s .fail path left fa-spin on the un-replaced header so the glyph span forever - clear it on failure. (2) Extract the force-reload button markup into intropage_panel_reload_button() and add a focused Pest test asserting it renders fa-sync-alt, instead of suppressing coverage of the behavior; only the thin exit-bound print glue stays coverage-ignored.
bmfmancini
approved these changes
Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces the panel Reload Panel header glyph: it was
fa-retweet, now it is the proper refresh iconfa-sync-alt, and it spins (fa-spin) while the panel reloads (the spin clears automatically becausereload_panel()replaces the panel header).Related Issue
N/A — small glyph/UX fix.
Motivation and Context
fa-retweetreads as a share/retweet action rather than a refresh. The refresh icon communicates the "reload this panel" action clearly, and spinning it gives feedback during the reload.How Has This Been Tested?
Loaded a dashboard with a force-reloadable panel: the header shows the refresh glyph, and clicking it spins the glyph until the panel content is replaced.
php -lclean onincludes/functions.php. No translatable strings changed (tokenizer-based i18n check unaffected).Types of changes
Checklist: