Repository navigation
issue: shorten flowview graph drilldown button title to 'NetFlow' - #292
Merged
Merged
Conversation
The graph action menu now renders each drilldown button's title as a visible label, so 'View NetFlow Traffic In Range' reads as an overlong menu entry. Shorten it to 'NetFlow' and regenerate locales/po/cacti.pot for the changed translatable string.
TheWitness
requested review from
bmfmancini and
xmacan
and
a balanced review from Copilot
October 12, 2026 18:40
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused UI text change is consistent, translated, and fully documented.
0 open findings
What changed in this PR
Shortens the FlowView graph drilldown label to align with Cacti’s concise action-menu labels.
Changes:
- Renames the visible title to “NetFlow.”
- Updates the gettext template and changelog.
| File | Description |
|---|---|
setup.php |
Shortens the graph button title. |
locales/po/cacti.pot |
Updates the translatable string. |
CHANGELOG.md |
Documents the label change. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
The integration-test workflow installed Cacti's config.php but never created the plugin's own config.php, so 'plugin_manage.php --plugin=flowview --install' failed with 'needs configuration'. Copy config.php.dist to config.php (it defaults to using the Cacti database) before the install step.
Creating config.php persistently made the FlowviewLifecycleTest 'no config file exists' case reach flowview_connect() and error. Create config.php only for the install step and remove it immediately, so the unit tests run with no config file and the poller falls back to the Cacti database.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cacti's graph action (drilldown) menu now renders each registered button's
titleas a visible text label. With that change, this plugin's graph button title "View NetFlow Traffic In Range" reads as an overlong entry in the menu.This shortens it to NetFlow, matching the concise, label-style wording of the other drilldown actions (Details, Realtime, Time View, etc.). The existing
fas fa-waterglyph is unchanged and already follows the preferrediconLink+ Font Awesome drilldown format.Changes
setup.php—flowview_graph_button(): titleView NetFlow Traffic In Range→NetFlow.locales/po/cacti.pot— regenerated for the changed translatable string (required by the i18n gate).CHANGELOG.md— entry underdevelop.Testing
php -l setup.php— clean.php tests/bin/check-i18n-pot.php origin/develop— OK (pot included).setup.phpis in the patch-coverage$unmeasured_allowlist, so no measured lines change.