Repository navigation
feature: Extend Graph Width options up to 1500 pixels - #49
Merged
Merged
Conversation
TheWitness
requested review from
bmfmancini and
xmacan
and
a balanced review from Copilot
September 29, 2026 23:22
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused configuration and documentation changes correctly implement the described width range.
Review effort: Balanced
Findings: None
What changed in this PR
Extends Cycle Graphs’ selectable graph widths from 700 to 1500 pixels.
Changes:
- Adds 800–1500 pixel width options in 100-pixel increments.
- Documents the enhancement in the changelog.
| File | Description |
|---|---|
setup.php |
Adds the new graph-width options. |
CHANGELOG.md |
Records the feature under development. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
bmfmancini
previously approved these changes
Sep 30, 2026
The Enforce-coverage-of-changed-lines gate reported 0/9 for the new graph width options because pcov auto-scopes to the Composer root (cacti/) and skips cacti/plugins/, so setup.php was never instrumented. Switch the coverage driver to xdebug (matching the ci/coverage-xdebug rollout) so the plugin's own sources are measured; the existing CycleConfigArraysTest already exercises the added lines.
…h-1500 # Conflicts: # CHANGELOG.md
browniebraun
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the Cycle plugin Graph Width setting range from a previous maximum of 700 pixels up to 1500 pixels, adding 800, 900, 1000, 1100, 1200, 1300, 1400, and 1500 pixel options in 100-pixel increments.
Changes
setup.php: append 800-1500 (100px steps) to the$cycle_widthoptions array incycle_config_arrays().CHANGELOG.md: note the new width options under--- develop ---.Validated with
php -l(no syntax errors).