Feature-detect Cacti 1.3 instead of CACTI_VERSION in audit_utilities_array

[TheWitness]

Problem

audit_utilities_array() (the utilities_array hook, which adds a "View Audit
Log" entry under Technical Support on the Utilities page) gates on a version
string:

if (version_compare(CACTI_VERSION, '1.3.0', '<')) {
    ...
}

On 1.3 the Audit Log link is surfaced through config_arrays instead. But
current develop builds still report a version that compares < 1.3.0, so on
those builds this legacy block runs as well — adding the entry a second time,
and, if core no longer pre-populates the legacy $utilities['Technical Support']
section, running array_merge() against an unset key (TypeError).

Same unreliable CACTI_VERSION gating recently fixed in plugin_monitor (#270)
and plugin_flowview.

Fix

Detect Cacti 1.3 by a class it introduced (CactiTableFilter) rather than the
version string — the same signal used in the monitor fix — and leave the
string-bearing body untouched:

if (!class_exists('CactiTableFilter')) {
    if (api_plugin_user_realm_auth('audit.php')) {
        ...
    }
}

• True legacy Cacti (< 1.3, no CactiTableFilter): the entry is added exactly
  as before.
• Cacti 1.3+ and any develop build reporting < 1.3.0: the block is skipped, so
  the entry is never doubled and the array_merge() never runs on an unset key.

Only the gate line changes; the translatable strings are unchanged, so the i18n
template check stays green.

Testing

• php -l setup.php — no syntax errors.
• php tests/bin/check-i18n-pot.php <base> — exit 0 (no translatable-string
  changes).

[Copilot]

🟡 Changes recommended

The guard does not distinguish the menu implementations on develop, and required behavioral coverage is missing.

2 open findings

• Utility registration paths remain non-exclusive · New
• Add coverage for audit_utilities_array scenarios · New

What changed in this PR

Updates the audit plugin’s Utilities hook to inspect the menu structure rather than rely on Cacti’s version string.

Changes:

• Guard against a missing Technical Support section before merging the audit entry.
• Update the hook documentation and changelog.

File	Description
setup.php	Replaces the version gate with a section-existence check.
CHANGELOG.md	Documents the intended compatibility fix.

🧠 Review effort: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.