Repository navigation
ci: pin the database image and install locked shared test dependencies - #45
Open
somethingwithproof wants to merge 3 commits into
Open
somethingwithproof wants to merge 3 commits into
somethingwithproof wants to merge 3 commits into
Conversation
|
somethingwithproof
force-pushed
the
security/actions-hardening-20261013
branch
2 times, most recently
from
October 17, 2026 21:16
820ec4f to
26f9b81
Compare
somethingwithproof
marked this pull request as ready for review
October 17, 2026 23:48
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
somethingwithproof
force-pushed
the
security/actions-hardening-20261013
branch
from
October 17, 2026 23:55
26f9b81 to
c7368ec
Compare
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
somethingwithproof
changed the title
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI currently changes Cacti's Composer manifest and resolves dependencies during each run. Check out the current Cacti branch head, pin the MariaDB image, install committed locks through the shared core action, and run Composer as the runner user. Set read-only permissions, disable persisted checkout credentials, cap integration jobs at 45 minutes, and cancel superseded PR runs. Add Actions updates where missing.
The existing events, matrix, job names, PHPUnit configuration, coverage thresholds, plugin schema/localization checks and polling steps are retained. No plugin-local test manifest is added. Stream retains its own runtime dependency contract.
Validation: full actionlint including shellcheck passes. The shared harness passes Thold's Linux tests and FlowView/Stream unit tests. Syslog's two unit failures reproduce with the existing core Pest toolchain. GitHub integration checks on this PR must complete before merge.
Depends on Cacti/cacti#8345. Merge the shared core tooling before this caller migration. The tooling is sparse-checked out at the published helper commit because Cacti source archives exclude CI files. No secrets are passed to the helper.
Also fail when the background poller wait times out, so the log check cannot pass while polling is still running.
The poller wait step now exits 1 when poller_apcupsd.php is still running after its timeout, as routerconfigs already does, so a stuck poller fails the job instead of passing silently.