Skip to content

Found five hooks API missed in doc, and one is invalid #72

Open

Description

@ddb4github

In Plugin-Hook-API-Ref

  • Missed: device_threshold_autocreate, expand_title, is_device_in_maintenance, custom_2fa_login, utilities_tab
  • Invalid: report_filter link is broken. Also, report_filter is not found in any code(both of 1.2.x and develop branch)

As soon, I'll create a PR for new custom_denied, auth_profile_xxx since 1.2.0-beta3, and device_xxxx in develop branch

Activity

  1. netniV commented on May 31, 2020

    @netniV
    Member

    @ddb4github wasn't there a PR done for this? #73 I believe?

  2. ddb4github commented on May 31, 2020

    @ddb4github
    ContributorAuthor

    @ddb4github wasn't there a PR done for this? #73 I believe?

    No I'm not sure the desc of device_threshold_autocreate, expand_title, is_device_in_maintenance, and custom_2fa_login. Also not sure delete report_filter or keep.

    BTW, custom_2fa_login is more like 'develop' branch API, not for '1.2.x'

    So I just update utilities_tab and some other API in #73

  3. netniV commented on Jun 1, 2020

    @netniV
    Member

    It is and should have 1.3 as its version introduced. The documentation is not version dependant at the moment because it would be too much work. If we include any version specific features, these should be tagged in the text to say when it is available or working from.

  4. added a commit that references this issue on Mar 9, 2026
    e123358
  5. somethingwithproof commented on Oct 13, 2026

    @somethingwithproof
    Member

    Current Plugin-Hook-API-Ref.md documents utilities_tab and uses the corrected report_filters link, but still lacks device_threshold_autocreate, expand_title, is_device_in_maintenance and custom_2fa_login. Merged #229 only partially covers this report; it remains open for those four hooks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions