Repository navigation
codegen: always compile uop fatal checks, add missing ones - #20
Open
Cacodemon345 wants to merge 1 commit into
Open
Cacodemon345 wants to merge 1 commit into
Cacodemon345 wants to merge 1 commit into
Conversation
The x86-64 backend's uop handlers only reported unhandled register sizes and out-of-range immediates under RECOMPILER_DEBUG, so in normal builds they silently emitted nothing and returned success. Drop the guards so these checks are always active, as they already are on arm64 and LoongArch64. Building the checks in uncovered format strings with more conversions than arguments (FABS, FCHS, FSQRT, PF2ID, PFRCP, PFRSQRT, PI2FD); fix them. Also add the fatal calls that were missing: - x86-64 CALL_FUNC_RESULT_ORDERED now rejects a non-32-bit destination, like CALL_FUNC_RESULT. - arm64 and LoongArch64 MEM_LOAD_ABS / MEM_LOAD_REG now end their result write-back chains with a fatal, like the call chains above them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KXB93KqPEdHSKMo4piNENg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The x86-64 backend's uop handlers only reported unhandled register sizes
and out-of-range immediates under RECOMPILER_DEBUG, so in normal builds
they silently emitted nothing and returned success. Drop the guards so
these checks are always active, as they already are on arm64 and
LoongArch64.
Building the checks in uncovered format strings with more conversions
than arguments (FABS, FCHS, FSQRT, PF2ID, PFRCP, PFRSQRT, PI2FD); fix
them.
Also add the fatal calls that were missing:
like CALL_FUNC_RESULT.
result write-back chains with a fatal, like the call chains above them.
Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01KXB93KqPEdHSKMo4piNENg