Repository navigation
Credit the authors on nine patterns that were missing them - #258
Merged
Merged
Conversation
These patterns were skipped by the #143 migration: eight use heading variants the script did not match ("Contributor(s) & Acknowledgment", "Author(s) & Acknowledgement"), and integrating-oss listed names as non-bullet lines. Add authors frontmatter, normalize each heading so the authors hook finds it, and remove the hand-written names so they are not duplicated. Keep trailing prose. Move per-person role notes on oss-tutorials into a sentence, since the hook drops bullets. Register amber-budden, clare-dillon, michael-rossetti, russell-poldrack and stephen-walli in authors.yml.
Member
Author
|
Closes #256 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
Nine patterns name their contributors on the page, but those names were never connected to the site's Authors page. Those patterns weren't listed under the people who wrote them, and their RSS feed items had no "By…" credit. They were missed when the patterns moved to the new author system in June.
What changes
Please check
After merging, the Authors page should list all five new people, and Clare should have eight patterns.